Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upRFC: Rename the `size_hint` method of `Iterator` to `len_hint`. #1032
Conversation
CloudiDust
added some commits
Apr 4, 2015
This comment has been minimized.
This comment has been minimized.
|
I think it's a perfectly fine 1.0 breaking change to just rename it. It's an easy grep. |
CloudiDust
changed the title
RFC: Add `len_hint` to `Iterator` and deprecate `size_hint`.
RFC: Rename the `size_hint` method of `Iterator` to `len_hint`.
Apr 5, 2015
CloudiDust
closed this
Apr 5, 2015
This comment has been minimized.
This comment has been minimized.
|
There was some issue with git or GitHub that my new commits were not showing in this PR, and I had no idea how to correct that, so I decided to start over with #1034. Sorry for the confusion. |
CloudiDust
referenced this pull request
Apr 5, 2015
Closed
RFC: Deprecate `Iterator::size_hint` and `ExactSizeIterator` for better named alternatives. #1034
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
CloudiDust commentedApr 4, 2015
This change is originally brought up in this discuss thread.
Rendered View