Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign up0401: misc improvements #1189
Conversation
nrc
self-assigned this
Jul 5, 2015
nrc
added
the
T-lang
label
Jul 5, 2015
This comment has been minimized.
This comment has been minimized.
|
Hear ye, hear ye. This RFC is moving into final comment period. |
nikomatsakis
added
the
final-comment-period
label
Aug 7, 2015
This comment has been minimized.
This comment has been minimized.
|
FCP for such superficial changes? |
This comment has been minimized.
This comment has been minimized.
|
@tshepang I don't expect a lot of comments :) but we decided it's easier to just FCP everything. |
This comment has been minimized.
This comment has been minimized.
|
I object! (Okay, not really) |
This comment has been minimized.
This comment has been minimized.
|
Unsurprisingly, we'll take this one. :) Thanks @tshepang ! |
nikomatsakis
added a commit
that referenced
this pull request
Aug 14, 2015
nikomatsakis
merged commit 4dc6673
into
rust-lang:master
Aug 14, 2015
tshepang
deleted the
tshepang:patch-1
branch
Aug 18, 2015
Centril
added
the
not-rfc
label
Nov 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
tshepang commentedJul 5, 2015
No description provided.