Skip to content

/rfcs

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update FOLLOW set for `ty` tokens #1209

Merged
merged 1 commit into from Aug 14, 2015

Conversation

Reviewers
No reviews
Assignees

@nikomatsakis nikomatsakis

Labels
A-macros A-syntax T-lang final-comment-period
Projects
None yet
Milestone
No milestone
6 participants
@alexcrichton @cmr @nikomatsakis @dgrunwald @huonw @Centril
@alexcrichton
Copy link
Member

alexcrichton commented Jul 13, 2015

Accounts for rust-lang/rust#27000

cc @cmr

@alexcrichton alexcrichton added the T-lang label Jul 13, 2015

@cmr

This comment has been minimized.

Sign in to view
Copy link
Member

cmr commented Jul 14, 2015

r+
@nikomatsakis

This comment has been minimized.

Sign in to view
Copy link
Contributor

nikomatsakis commented Jul 16, 2015

cc @pnkfelix
@nikomatsakis

This comment has been minimized.

Sign in to view
Copy link
Contributor

nikomatsakis commented Jul 16, 2015

Hard to argue against this!

@nrc nrc assigned alexcrichton Jul 16, 2015

@nikomatsakis nikomatsakis assigned nikomatsakis and unassigned alexcrichton Jul 16, 2015

@nikomatsakis

This comment has been minimized.

Sign in to view
Copy link
Contributor

nikomatsakis commented Jul 16, 2015

To be clear, did code for this already land?
@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member Author

alexcrichton commented Jul 16, 2015

@nikomatsakis yeah it landed in rust-lang/rust#27000 (although we can revert if we don't want to accept this RFC)
@dgrunwald

This comment has been minimized.

Sign in to view
Copy link
Contributor

dgrunwald commented Jul 18, 2015

Any reason we don't allow { after ty?
In particular, I'd like to write a macro that mimics function definition syntax:
($paramname:ident) -> $rettype:ty $body:block
@nikomatsakis

This comment has been minimized.

Sign in to view
Copy link
Contributor

nikomatsakis commented Jul 21, 2015

@dgrunwald yes, seems like there isn't a good one. also where keyword.

@huonw huonw referenced this pull request Jul 31, 2015

Closed

Amend macro future proofing RFC #733

@huonw

This comment has been minimized.

Sign in to view
Copy link
Member

huonw commented Jul 31, 2015

cc #733
@nikomatsakis

This comment has been minimized.

Sign in to view
Copy link
Contributor

nikomatsakis commented Jul 31, 2015

Hear ye, hear ye. This RFC is entering final comment period.

/me thought it already was

@nikomatsakis nikomatsakis added the final-comment-period label Jul 31, 2015

@nikomatsakis nikomatsakis merged commit 4083ad7 into rust-lang:master Aug 14, 2015

@Centril Centril added A-macros A-syntax labels Nov 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.