Amend RFC 1270 to describe actual implementation

[durka]

Change reason to note and remove use.

This isn't a new RFC, just some edits to reflect reality. rust-lang/rust#30206 (comment)

[llogiq]

👍

[llogiq]

note that use or some other extension may still be in future Rust.

[durka]

Yes I only removed it from the example code, not from the Alternatives section.

[liigo]

to describe actual implementation

Implementation should obey the RFC, not 'vice versa'. So maybe you would give an actual reason to make this change.

[llogiq]

As I said in my other (now closed because of git history issues) PR, this is a minor change, which (as written on the RFC itself) reflects actual usage of the internal feature better, which is a good indicator of the needs of library authors.

[liigo]

@llogiq

reflects actual usage of the internal feature better

could you elaborate?

As I said before (in other PR), I'm not object to this change, just ask for writing down why we change this, in commit messages, so people can trace it later.

FWIW, what I means 'the RFC' is the RFC that was merged into rust-lang/rfcs by libs team, not the rfc PR in your own repo.

[llogiq]

As for the rationale, look at current usage of the rustc-internal deprecation feature. Though the field was named reason, it often contained e.g. directions on what to use else instead of the actual reason for the deprecation. Since current use is so diverse, choosing a less specific name conveys that the field can be broadly used and leaves us free to choose to add a reason field later should we deem it useful.

[alexcrichton]

🔔 This RFC is now entering its week-long final comment period 🔔

[alexcrichton]

The libs team discussed this today and the conclusion was to merge, thanks @durka!

[durka]

My first RFC!

[llogiq]

Yay! 👍