Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd `[` to the FOLLOW(ty) in macro future-proofing rules. #1462
Conversation
This comment has been minimized.
This comment has been minimized.
|
Discussed with lang-team at meeting tonight; putting into Final Comment Period (FCP) now. (The reason for the quick FCP is because if we want to fix this, the only sensible time to do so is during the beta period, before the warning is promoted to a hard error.) |
This comment has been minimized.
This comment has been minimized.
|
Hear ye, hear ye. This RFC is now entering final comment period. |
pnkfelix
added
T-lang
final-comment-period
labels
Jan 14, 2016
This comment has been minimized.
This comment has been minimized.
|
Yes please. |
nrc
assigned
pnkfelix
Jan 15, 2016
This comment has been minimized.
This comment has been minimized.
|
|
This comment has been minimized.
This comment has been minimized.
|
Seems somewhat risky, were "type-level integers" to be added and made usable where constexprs are. Consider |
This comment has been minimized.
This comment has been minimized.
|
@cmr isn't that |
This comment has been minimized.
This comment has been minimized.
|
@durka I have no idea, but I wouldn't expect so. Lots of finnicky details around those proposals. |
This comment has been minimized.
This comment has been minimized.
|
Well maybe I don't understand what you mean. What is Certainly merging this RFC restricts future syntax choices slightly. I don't really have an opinion one way or the other, except I'm against breaking all of @retep998's crates :) |
This comment has been minimized.
This comment has been minimized.
|
In general a proposal could have the moral equivalent of expressions appearing in type-position. Whether they'd be treated as expr, for macros, or not I do not know. |
This comment has been minimized.
This comment has been minimized.
|
@cmr good point. My expectation though is that if we were ever to
embed expressions into types, we would need to have some kind of
"introduction syntax" anyhow. For example, I believe I've seen it
proposed that one might write `{expr}`, in which case the issue is
moot.
|
This comment has been minimized.
This comment has been minimized.
|
Huzzah! The language design subteam has decided to accept this RFC. |
nikomatsakis
referenced this pull request
Jan 22, 2016
Closed
Add `[` to the follow set for `ty` #31135
nikomatsakis
merged commit 6fef0b3
into
rust-lang:master
Jan 22, 2016
This comment has been minimized.
This comment has been minimized.
|
Created tracking issue rust-lang/rust#31135 for this change specifically. |
pnkfelix commentedJan 14, 2016
Add
[to the FOLLOW(ty) in macro future-proofing rules (RFC #550 )This is to address the regression rust-lang/rust#30923