Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amend RFC2603 to allow mangled identifiers to start with a digit. #2705

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@eddyb
Copy link
Member

commented May 29, 2019

This was suggested by @pnkfelix in #2603 (comment), and @michaelwoerister seemed to agree to it, but it didn't make it into the RFC before merging.

I also removed the 0-9 -> A-J rewriting of Punycode's base-36 encoding, as it only existed to avoid having identifiers start with decimal digits, which would now work.

cc @rust-lang/compiler Do we have a procedure for amending RFCs?

@michaelwoerister

This comment has been minimized.

Copy link
Contributor

commented May 29, 2019

Looks good to me!

@eddyb eddyb force-pushed the eddyb:mangling-underscore-escaping branch from e8ac8fb to e925a40 May 29, 2019

@nikomatsakis

This comment has been minimized.

Copy link
Contributor

commented May 29, 2019

We often do an FCP for amendments, but I also think it's ok to "just do it" if it is small and not controversial amongst the folks who were active in the RFC itself. I am fine with this change (but I've not been following the RFC closely).

@eddyb

This comment has been minimized.

Copy link
Member Author

commented May 30, 2019

I've now incorporated the changes into rust-lang/rust#57967, including testing them against alexcrichton/rustc-demangle#26 (which has been merged and published).

@SimonSapin SimonSapin changed the title Amend RFC2603 to allow identifiers to start with a digit. Amend RFC2603 to allow mangled identifiers to start with a digit. May 31, 2019

@SimonSapin

This comment has been minimized.

Copy link
Contributor

commented May 31, 2019

I took the liberty of adding “mangled” to the title. Without context, the title alone sounded like a change to Rust source syntax.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.