Skip to content

/rfcs

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Un-feature-gate if let and tuple indexing #450

Merged
merged 2 commits into from Dec 2, 2014

Conversation

Reviewers
No reviews
Assignees

@alexcrichton alexcrichton

Labels
A-control-flow A-syntax A-tuples
Projects
None yet
Milestone
No milestone
7 participants
@alexcrichton @blaenk @netvl @brendanzab @nrc @arcto @Centril
@alexcrichton
Copy link
Member

alexcrichton commented Nov 7, 2014

Rendered
@blaenk

This comment has been minimized.

Sign in to view
Copy link

blaenk commented on text/0000-un-feature-gate-some-more-gates.md in ee82af8 Nov 8, 2014

Does this perhaps mean to say "with very few reported ICEs" instead of "without very few reported ICEs"?

This comment has been minimized.

Sign in to view
Copy link
Owner Author

alexcrichton replied Nov 8, 2014

Oops yes, thanks!
@blaenk

This comment has been minimized.

Sign in to view
Copy link

blaenk commented on text/0000-un-feature-gate-some-more-gates.md in ee82af8 Nov 8, 2014

Same as previous comment.
@blaenk

This comment has been minimized.

Sign in to view
Copy link
Contributor

blaenk commented Nov 8, 2014

I completely agree with this. These are pretty simple and straightforward features (at least from the perspective of the user. I guess the compiler's perspective matters more) for how useful they are.
@netvl

This comment has been minimized.

Sign in to view
Copy link

netvl commented Nov 8, 2014

+1. These are very convenient features which I use all the time, and they don't seem to be very large/extensive to cause feature bloat.
@brendanzab

This comment has been minimized.

Sign in to view
Copy link
Member

brendanzab commented Nov 10, 2014

I am a fan of letting in tuple indexing - still unsure about if let though :/

@alexcrichton alexcrichton self-assigned this Nov 13, 2014

@nrc

This comment has been minimized.

Sign in to view
Copy link
Member

nrc commented Nov 17, 2014

+1
@arcto

This comment has been minimized.

Sign in to view
Copy link

arcto commented Nov 17, 2014

+1. I use them every day.

@aturon aturon referenced this pull request Nov 24, 2014

Closed

Stabilization metabug: 1.0-alpha #19260

140 of 142 tasks complete

@orium orium referenced this pull request Nov 27, 2014

Closed

unfeature-gate tuple-indexing, then replace tuple indexing traits / methods accordingly #18006

@nrc

This comment has been minimized.

Sign in to view
Copy link
Member

nrc commented Dec 2, 2014

We (the Rust team) have discussed this and decided to merge it.

Tracking issue

@nrc nrc merged commit 70cfff1 into rust-lang:master Dec 2, 2014

@chriskrycho chriskrycho referenced this pull request Dec 31, 2016

Closed

Document all features in the reference #38643

0 of 17 tasks complete

@chriskrycho chriskrycho referenced this pull request Mar 11, 2017

Closed

Document all features #9

18 of 48 tasks complete

@Centril Centril added A-syntax A-control-flow A-tuples labels Nov 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.