Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upAllow the `Self` type to be used in impls. #522
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
And an implementation to show how easy it is - less than 100 lines of code changed (including the test) and no changes outside of libsyntax. |
nrc
self-assigned this
Dec 14, 2014
This comment has been minimized.
This comment has been minimized.
|
Nice! I've often wanted this. |
mdinger
referenced this pull request
Dec 14, 2014
Closed
Does `&self` still desugar to `self: &Self`? #211
This comment has been minimized.
This comment has been minimized.
sinistersnare
commented
Dec 14, 2014
|
+1 simple and useful for macros |
This comment has been minimized.
This comment has been minimized.
|
+1, always seemed like an oversight that you couldn't do this. |
This comment has been minimized.
This comment has been minimized.
|
It'd certainly be convenient and I've kind of expected we'll add it sooner or later. As far as the implementation goes, I would have expected to handle it in astconv, but I guess doing it in libsyntax is ok too and avoids needing to modify |
This comment has been minimized.
This comment has been minimized.
|
I realised today that if we want to accommodate |
This comment has been minimized.
This comment has been minimized.
|
On Mon, Dec 15, 2014 at 05:27:54PM -0800, Nick Cameron wrote:
I expect this to fall out of the refactoring for AT we've been |
This comment has been minimized.
This comment has been minimized.
|
This RFC has been accepted, r=nikomatsakis Small, easy to implement, and widely desired. This will NOT block 1.0. |
nrc commentedDec 14, 2014
Closes #310
See also some discussion in discuss and discussion in the Rust issue tracker.