Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upuse globs as RFC #867
Conversation
This comment has been minimized.
This comment has been minimized.
|
Nit: "glob" refers to |
This comment has been minimized.
This comment has been minimized.
|
@sfackler I thought so, but the reference calls |
This comment has been minimized.
This comment has been minimized.
|
@seanmonstar Then I guess the reference is wrong, or at least slightly inaccurate with regard to naming. I think the reference might be using the term ‘glob’ in a slightly more general sense, referring to any sort of expansion done by shells (both |
This comment has been minimized.
This comment has been minimized.
|
+1 |
This comment has been minimized.
This comment has been minimized.
|
|
This comment has been minimized.
This comment has been minimized.
jfager
commented
Feb 17, 2015
|
+1, been bumping into this a lot recently. |
This comment has been minimized.
This comment has been minimized.
|
So, to be clear, the RFC proposed is not allowing Is that intentional? (It seems reasonable to allow it, but also reasonable to delay implementing such an extension, if for some reason its more difficult in the |
This comment has been minimized.
This comment has been minimized.
|
@pnkfelix that's actually in the Unresolved Questions section. I can see it being useful, but wasn't sure the consensus. |
This comment has been minimized.
This comment has been minimized.
|
@seanmonstar ah, right you are, sorry for the noise |
This comment has been minimized.
This comment has been minimized.
reem
commented
Feb 23, 2015
|
+1, I have wanted this. |
pnkfelix
referenced this pull request
Mar 4, 2015
Closed
allow renaming `old as new` within use "glob" brackets #933
This comment has been minimized.
This comment has been minimized.
|
Thank you very much for your contribution! Clearly lots of people really like this idea. However, it is something we can add backwards compatibly after 1.0 ships (and it seems like we can continue getting by without it in the meantime). So, we are going to postpone this RFC (see issue #933), but hopefully will address it sometime after 1.0 ships. Thanks again |
pnkfelix
closed this
Mar 4, 2015
pnkfelix
added
the
postponed
label
Mar 4, 2015
This comment has been minimized.
This comment has been minimized.
|
@pnkfelix being postponed, would this mean accepted essentially? If I or someone else were to create a PR for 1.1, would that be accepted? |
This comment has been minimized.
This comment has been minimized.
|
@seanmonstar no, it means that a decision has been postponed. Post-1.0, you could open a new RFC PR or re-open this one. |
This comment has been minimized.
This comment has been minimized.
|
@nrc You said i could re-open this one? I don't believe I have permission to do so (I don't see the button), but if I were to open an new PR, it would be the same commit exactly... |
This comment has been minimized.
This comment has been minimized.
|
"re-open" means ask someone with the right privs to re-open for you, I guess (due to the GH security model, not Rust policy), but creating a new PR (like you've done) is totally fine. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
nixpulvis
commented
Jan 11, 2016
|
Related #1400 |

seanmonstar commentedFeb 16, 2015
Allow aliasing imports when used in a glob import.
Rendered