Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upRetire RFC 8 (intrinsics) without implementing it. #948
Conversation
nrc
assigned
brson
Mar 9, 2015
This comment has been minimized.
This comment has been minimized.
lfairy
commented on text/0008-new-intrinsics.md in 2368991
Mar 15, 2015
|
I think this should include an explanation as to why it wasn't implemented, or at least a link to this PR. |
nrc
added
the
T-lang
label
May 15, 2015
This comment has been minimized.
This comment has been minimized.
|
Hear ye, hear ye. This RFC is now in final comment period until June 2nd. |
nikomatsakis
added
the
final-comment-period
label
May 26, 2015
This comment has been minimized.
This comment has been minimized.
DanielKeep
commented
May 27, 2015
|
As an uninformed observer, I concur with @lfairy: the RFC text looks like a slam-dunk improvement, so it'd be nice to have a record as to why the RFC should be dropped. From another perspective: there is (at least for me) a perception of RFCs requiring a good deal of rigour to be accepted. It'd be a little troubling if the core team could come along and nix an RFC after it's already been accepted and merged because "I do not like the design here". Having a concrete explanation added to the text would mitigate that. (Note: I'm not trying to imply anything by this, I just wanted to point out a possible point of future contention that occurred to me.) |
This comment has been minimized.
This comment has been minimized.
|
It's always been the case that merely having an RFC be accepted is not a guarantee that the changes described therein will be implemented. From the RFC README:
In this particular case, the topic at hand (intrinsics) are considered an unstable part of Rust. The fundamental ideas in this RFC may still be good (though in re-reading the RFC I found it rather vague in many details), but enough time has elapsed that when it comes time to "stabilize" intrinsics, it's probably best to write a fresh RFC at that time. Basically, it's a good idea to have the design phase and the implementation phase be close enough together that people can still remember the details! So on those grounds alone I think @brson is probably right that it's a good idea to just "deprecate" the RFC and revisit it later. |
nikomatsakis
merged commit 2368991
into
rust-lang:master
Jun 3, 2015
This comment has been minimized.
This comment has been minimized.
|
This RFC is considered accepted. Per the comments, I added some additional explanatory text explaining that while the design may be a useful starting point, it should be revisited in light of all the time that has passed. --- Language Design Subteam |
brson commentedMar 6, 2015
This RFC changed the design of intrinsics with the goal of eliminating
the need for creating inlined wrappers around them. In the meantime,
the critical intrinsics for which this have been a problem have all
had their wrappers removed (afaik without solving the problem this
RFC set out to solve).
In the meantime, I decided I do not like the design here that unifies
intrinsics and lang items - they are sufficiently different to warrant
different names.
The ideas here have bitrotted and when we need to solve this for real
we should start over.