New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hover infinite loop #1170

Merged
merged 1 commit into from Dec 7, 2018

Conversation

Projects
None yet
3 participants
@alexheretic
Copy link
Member

alexheretic commented Dec 6, 2018

extract_docs if-continue could cause endless looping if moving up & top line meta.

after fix:

Fixes #1168

Fix potential hover infinite loop
extract_docs continue clause could cause endless looping if moving up & 
top line meta

@alexheretic alexheretic changed the title Fix potential hover infinite loop Fix hover infinite loop Dec 6, 2018

@alexheretic

This comment has been minimized.

Copy link
Member

alexheretic commented Dec 7, 2018

This fixes #1016 too. Well done @vi for finding a beautifully simple way to reproduce it.

@alexheretic

This comment has been minimized.

Copy link
Member

alexheretic commented Dec 7, 2018

@nrc it'd be nice to backport this fix to stable too I think.

@nrc nrc merged commit bfa1371 into rust-lang:master Dec 7, 2018

1 check failed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
@nrc

This comment has been minimized.

Copy link
Member

nrc commented Dec 7, 2018

\o/ Thanks! If we do a point release for stable I'll include this, but I don't think we can do a point release just for this

@alexheretic alexheretic deleted the alexheretic:fix-hover-inf-loop branch Dec 7, 2018

@vi

This comment has been minimized.

Copy link

vi commented Dec 7, 2018

How do I rustup the fix into nightly?

Packet is not the only problematic item, I keep on restarting vscode againg and again.

@alexheretic

This comment has been minimized.

Copy link
Member

alexheretic commented Dec 7, 2018

@vi the rust-lang/rust rls submodule will have to be updated to bfa1371 or later with a pull request. After merging rls will be fixed the following nightly release.

In general it takes a few days to a week for a fix in rls to filter through to the nightly release.

bors added a commit to rust-lang/rust that referenced this pull request Dec 17, 2018

Auto merge of #56911 - rust-lang:stable-1.31.1, r=Mark-Simulacrum
[stable] 1.31.1 point release

Rust 1.31.1 is scheduled to be released on Thursday 20th, with the following changes:

* #56562: Update libc version required by rustc *(different patch made by me)*
* #56615: Update the book to fix some edition-related bugs
* rls submodule update to [`b379ef7`](rust-lang/rls@b379ef7), including:
  * rust-lang/rls#1170: Fix for common infinte loop regression
  * rust-lang/rls#1171: Can't jump to std defs

r? @Mark-Simulacrum
cc @rust-lang/core @rust-lang/release

bors added a commit to rust-lang/rust that referenced this pull request Dec 18, 2018

Auto merge of #56911 - rust-lang:stable-1.31.1, r=Mark-Simulacrum
[stable] 1.31.1 point release

Rust 1.31.1 is scheduled to be released on Thursday 20th, with the following changes:

* #56562: Update libc version required by rustc *(different patch made by me)*
* #56615: Update the book to fix some edition-related bugs
* rls submodule update to [`b379ef7`](rust-lang/rls@b379ef7), including:
  * rust-lang/rls#1170: Fix for common infinte loop regression
  * rust-lang/rls#1171: Can't jump to std defs

r? @Mark-Simulacrum
cc @rust-lang/core @rust-lang/release

bors added a commit to rust-lang/rust that referenced this pull request Dec 18, 2018

Auto merge of #56911 - rust-lang:stable-1.31.1, r=Mark-Simulacrum
[stable] 1.31.1 point release

Rust 1.31.1 is scheduled to be released on Thursday 20th, with the following changes:

* #56562: Update libc version required by rustc *(different patch made by me)*
* #56615: Update the book to fix some edition-related bugs
* rls submodule update to [`b379ef7`](rust-lang/rls@b379ef7), including:
  * rust-lang/rls#1170: Fix for common infinte loop regression
  * rust-lang/rls#1171: Can't jump to std defs

r? @Mark-Simulacrum
cc @rust-lang/core @rust-lang/release

@Xanewok Xanewok referenced this pull request Dec 20, 2018

Merged

1.31.1 announcement #350

netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this pull request Dec 22, 2018

he
Upgrade rust to version 1.31.1.
Pkgsrc changes:
 * Sadly, I had to reinstate the "make tar files" rust code to make
   it possible to build cross-compiled bootstrap kits.
 * Add an adjustable "BUILD_TARGET", "dist" for cross-building
   a bootstrap kit, "build" for a normal native build.
 * New bootstrap kits built for NetBSD/powerpc, NetBSD/earmv7hf,
   and NetBSD/sparc64 version 1.31.1.
 * gcc-wrap script amended to also drop -Wl,--enable-new-dtags
   (so it could be used outside pkgsrc)
 * Worked around use of AtomicU64 in release build tool (ugly band-aid patch).
   Some platforms lack support for that type and associated operations.

Upstream changes:
 - [Fix Rust failing to build on `powerpc-unknown-netbsd`][56562]
 - [Fix broken go-to-definition in RLS][rls/1171]
 - [Fix infinite loop on hover in RLS][rls/1170]

[56562]: rust-lang/rust#56562
[rls/1171]: rust-lang/rls#1171
[rls/1170]: rust-lang/rls#1170

Xanewok added a commit to Xanewok/rust that referenced this pull request Jan 3, 2019

[beta] Update RLS to include 100% CPU on hover bugfix
Beta backport of a fix that already was backported to stable,
see rust-lang#56726 and
rust-lang/rls#1170 for the underlying RLS issue.

Xanewok added a commit to Xanewok/rust that referenced this pull request Jan 3, 2019

[beta] Update RLS to include 100% CPU on hover bugfix
Beta backport of a fix that already was backported to stable,
see rust-lang#56726 and
rust-lang/rls#1170 for the underlying RLS issue.

Also includes the fix for rust-lang/rls#1154
(respecting target-dir specified in .cargo/config for RLS artifacts).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment