Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rls-vfs line loading inclusivity #1600

Merged
merged 2 commits into from Jun 20, 2022

Conversation

bennetthardwick
Copy link
Contributor

@bennetthardwick bennetthardwick commented Dec 9, 2019

The load_lines method and load_span methods were returning incorrect regions. load_lines was return one line less and load_span was returning one character less.

Now that load_lines returns the correct number of lines, I updated load_line to use it.

@bennetthardwick
Copy link
Contributor Author

@bennetthardwick bennetthardwick commented Dec 17, 2019

Hey @Xanewok could you take a look when you get a chance?

@bddap
Copy link

@bddap bddap commented Feb 12, 2020

Perhaps related: rust-lang/vscode-rust#662

@bennetthardwick
Copy link
Contributor Author

@bennetthardwick bennetthardwick commented Feb 12, 2020

This change doesn't change any existing behaviour, just fixes up a function that isn't used anywhere internally (just yet). So I don't think it'll fix that issue unfortunately.

@Xanewok
Copy link
Member

@Xanewok Xanewok commented Feb 12, 2020

That's still a useful PR and I'm really sorry that I didn't get back to that in reasonable time. I'll gladly merge that after reviewing :)

@Xanewok Xanewok reopened this Feb 12, 2020
@bennetthardwick
Copy link
Contributor Author

@bennetthardwick bennetthardwick commented Feb 12, 2020

Hey all good @Xanewok, there's no rush 👍

@Xanewok Xanewok merged commit 6ae8421 into rust-lang:master Jun 20, 2022
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants