Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upMake the workspace hack local to RLS #952
Conversation
nrc
merged commit 2b53d58
into
rust-lang:master
Jul 20, 2018
This comment has been minimized.
This comment has been minimized.
|
Thanks! |
matklad
deleted the
matklad:Ive-seen-hacks-you-people-wouldnt-believe
branch
Sep 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
matklad commentedJul 20, 2018
cc rust-lang/rust#42146
closes #925
After this, we could and should eliminate https://github.com/rust-lang/rust/blob/4260c8b1e4b273facf1072b9457dfaedd7f03f3e/src/Cargo.toml#L26-L40