From c5686c89413b3c6eead7b39637381ee353f8c05c Mon Sep 17 00:00:00 2001 From: Milo Moisson Date: Tue, 2 Apr 2024 13:35:12 +0200 Subject: [PATCH] fix: set the right postfix snippets competion source range Changed the completion item source_range to match the replaced text. Though in VS Code it may not be disturbing because the snippet is previewed in a box, but in Helix editor, it's previewed by applying the main text edit. --- crates/ide-completion/src/completions/postfix.rs | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/crates/ide-completion/src/completions/postfix.rs b/crates/ide-completion/src/completions/postfix.rs index 361ad821f4a4..554f7e081edb 100644 --- a/crates/ide-completion/src/completions/postfix.rs +++ b/crates/ide-completion/src/completions/postfix.rs @@ -333,8 +333,7 @@ fn build_postfix_snippet_builder<'ctx>( ) -> impl Fn(&str, &str, &str) -> Builder + 'ctx { move |label, detail, snippet| { let edit = TextEdit::replace(delete_range, snippet.to_owned()); - let mut item = - CompletionItem::new(CompletionItemKind::Snippet, ctx.source_range(), label); + let mut item = CompletionItem::new(CompletionItemKind::Snippet, delete_range, label); item.detail(detail).snippet_edit(cap, edit); let postfix_match = if ctx.original_token.text() == label { cov_mark::hit!(postfix_exact_match_is_high_priority);