New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish VSCode extension to marketplace? #2013
Comments
Distributing pre-build binaries of the language server is tricky. RLS does this via rustup, but we are not at the stage where we are ready to be officially packaged. |
I'm not talking about pre-built binaries, I'm primarily talking about the VSCode extension. I haven't actually looked into how exactly the language server is installed. Would it not be viable to distribute it as a crate? |
rust-analyzer contains git deps, so it can’t be published to crates.io. I think it should be possible to install it from git via cargo install, but that would make updating painfull (as everything would need to be rebuild from scratch). But yeah, perhaps it makes sense to distribute only the extension, to save one from needing npm to build... |
Like the idea with only extension published to VSCode :D I'm on Arch and I use AUR package: https://aur.archlinux.org/packages/rust-analyzer-git/ |
Could the extension be self contained as WASM? |
nope, we need to read files from disk, and there are editors which don't
use V8.
…On Tue, 15 Oct 2019 at 16:21, EliSnow ***@***.***> wrote:
Could the extension be self contained as WASM?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#2013>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AANB3M36I4HT24IOGUZJMDDQOW7W5ANCNFSM4JARGGAA>
.
|
WASI, then |
WASM is a bit slower than native. This is unfortunate for a language server, which needs to react very fast. Not sure if the difference is big enough to be noticable though. |
@matklad If I build rust-analyzer binary myself - what should be done to manually install it? Is it enough for it just to be in the path? |
Being in path is enough, yeah. cargo install usually takes care of that.
…On Thursday, 14 November 2019, Vyacheslav Kim (Kane) < ***@***.***> wrote:
@matklad <https://github.com/matklad> If I build rust-analyzer binary
myself - what should be done to manually install it? Is it enough for it
just to be in the path?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2013>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AANB3M5DMF6ZLVYVA5AYEFLQTTIG5ANCNFSM4JARGGAA>
.
|
Another vote for "please at least put the vs code extension on the vs code marketplace". |
This would be soooooo needed - the ergonomics of how to set this up manually in VSCode is really bad :( edit: Actually I was wrong, my statement was based on an outdated instruction that changed since then and the install process now indeed is much easier being just a single command (as long as npm is installed and previous res extension removed from VSCode) Thanks for all the great work. Using this project now makes the IDE experience MUCH better for rust! Sorry for the negative vibes @matklad (still I believe for discoverability reasons alone having rust analyser the default if people search for rust support in the marketplace is gonna be a big deal) |
I wouldn't call one-command installation "really bad". Significant effort were put into making the current installation process as easy as it is right now. I understand that we can do better, but this takes effort. I would advise against making +1 comments with (even slightly) negative emotional load, as they take everyone's time. |
@matklad we can probably close this now? |
Hi, is there a reason I have to clone the git repo and build everything from there instead of the way it works with RLS where I install the extension from inside VSCode and have the language server installed by the extension automatically?
The text was updated successfully, but these errors were encountered: