Skip to content

Remove handling of #[rustc_deprecated]#11983

Merged
bors merged 1 commit into
rust-lang:masterfrom
jhpratt:remove-rustc_deprecated
May 9, 2022
Merged

Remove handling of #[rustc_deprecated]#11983
bors merged 1 commit into
rust-lang:masterfrom
jhpratt:remove-rustc_deprecated

Conversation

@jhpratt

@jhpratt jhpratt commented Apr 14, 2022

Copy link
Copy Markdown
Member

This should be merged along with rust-lang/rust#95960.

Because the attribute still exists in rustc, I've left the definition here. With that said, any use of it is an error, so I've removed any handling of #[rustc_deprecated].

@lnicola

lnicola commented Apr 14, 2022

Copy link
Copy Markdown
Member

@bors r+

@bors

bors commented Apr 14, 2022

Copy link
Copy Markdown
Contributor

📌 Commit 5ca9ffe has been approved by lnicola

@jhpratt

jhpratt commented Apr 14, 2022

Copy link
Copy Markdown
Member Author

While I appreciate the quick r+, I think this should wait until the aforementioned PR lands :)

@lnicola

lnicola commented Apr 14, 2022

Copy link
Copy Markdown
Member

@bors r-

@lnicola

lnicola commented Apr 14, 2022

Copy link
Copy Markdown
Member

I wanted to merge it directly because it's only a cosmetic issue, but sure :-).

@jhpratt

jhpratt commented Apr 14, 2022

Copy link
Copy Markdown
Member Author

I mean, it's up to you 🤷 It's just that until that PR lands, whether something from stdlib is deprecated would be wrong. Which should be a short amount of time, but nonetheless.

@bors

bors commented May 1, 2022

Copy link
Copy Markdown
Contributor

☔ The latest upstream changes (presumably #12118) made this pull request unmergeable. Please resolve the merge conflicts.

@lnicola

lnicola commented May 9, 2022

Copy link
Copy Markdown
Member

@bors r+

@bors

bors commented May 9, 2022

Copy link
Copy Markdown
Contributor

📌 Commit 3c376e5 has been approved by lnicola

@bors

bors commented May 9, 2022

Copy link
Copy Markdown
Contributor

⌛ Testing commit 3c376e5 with merge 3d2d209...

@bors

bors commented May 9, 2022

Copy link
Copy Markdown
Contributor

☀️ Test successful - checks-actions
Approved by: lnicola
Pushing 3d2d209 to master...

@bors bors merged commit 3d2d209 into rust-lang:master May 9, 2022
@jhpratt jhpratt deleted the remove-rustc_deprecated branch May 9, 2022 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants