Add basic task support #3777
Merged
Add basic task support #3777
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds basic support for running `cargo build`, `cargo run`, etc.
Veetaha
reviewed
Mar 30, 2020
Contributor
|
Just curious, do we want to implement these kind of features in server side, such that it could also be used in other editors ? |
Contributor
We have Rust Analyzer: Run command, which is a strictly better feature. microsoft/language-server-protocol#944 tracks its addition to the protocol (no one is actively working on that right now) |
matklad
reviewed
Mar 31, 2020
Contributor
matklad
left a comment
matklad
left a comment
There was a problem hiding this comment.
r=me with a nit fixed!
bors d+
Contributor
|
bors r+ Thanks! |
bors bot
added a commit
that referenced
this pull request
Mar 31, 2020
3777: Add basic task support r=matklad a=Timmmm This adds basic support for running `cargo build`, `cargo run`, etc. Fixes #1935 I have tested this and it seems to work. There are two things I'm not sure about: 1. The workspace folder handling seems wrong - just get the first workspace folder? Is this just a TODO item? I don't know if it is right to lift `workspaceFolder` up to `activate()` but I couldn't see another way. 2. If you manually add an entry to `tasks.json` like this: ``` { "type": "cargo", "command": "build", "problemMatcher": [ "$rustc" ], "group": "build" } ``` then VSCode somehow magically knows to run `cargo build`. The documentation for `resolveTask` *sounds* like I should have to implement that for it to work: ``` * Resolves a task that has no [`execution`](#Task.execution) set. Tasks are * often created from information found in the `tasks.json`-file. Such tasks miss * the information on how to execute them and a task provider must fill in * the missing information in the `resolveTask`-method. ``` But then it also says this: ``` * This method will not be * called for tasks returned from the above `provideTasks` method since those * tasks are always fully resolved. A valid default implementation for the * `resolveTask` method is to return `undefined`. ``` Either way, it works without implementing it so the only thing I can think is that it is doing some kind of crazy pattern matching of the tasks returned by `provideTasks()` and the ones found in `tasks.json`. Co-authored-by: Tim <tdhutt@gmail.com>
Contributor
Timed out |
Contributor
|
hm, bors r+ ? |
Contributor
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds basic support for running
cargo build,cargo run, etc.Fixes #1935
I have tested this and it seems to work. There are two things I'm not sure about:
workspaceFolderup toactivate()but I couldn't see another way.tasks.jsonlike this:then VSCode somehow magically knows to run
cargo build. The documentation forresolveTasksounds like I should have to implement that for it to work:But then it also says this:
Either way, it works without implementing it so the only thing I can think is that it is doing some kind of crazy pattern matching of the tasks returned by
provideTasks()and the ones found intasks.json.