Add tracking of packed repr, use it to highlight unsafe refs #4743
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nashenas88
commented
Jun 4, 2020
Nashenas88
commented
Jun 4, 2020
Nashenas88
commented
Jun 4, 2020
Nashenas88
commented
Jun 4, 2020
Nashenas88
force-pushed
the
packed-ref-unsafe
branch
from
3afbf2d to
4dce98e
Compare
flodiebold
reviewed
Jun 11, 2020
Nashenas88
force-pushed
the
packed-ref-unsafe
branch
from
4dce98e to
a3e170c
Compare
matklad
reviewed
Jun 26, 2020
matklad
reviewed
Jun 26, 2020
Nashenas88
force-pushed
the
packed-ref-unsafe
branch
from
07545b2 to
eb27040
Compare
Nashenas88
commented
Jun 27, 2020
flodiebold
reviewed
Jun 28, 2020
Nashenas88
force-pushed
the
packed-ref-unsafe
branch
from
7ce51b0 to
54763c1
Compare
Nashenas88
force-pushed
the
packed-ref-unsafe
branch
from
54763c1 to
e5b3cd8
Compare
matklad
reviewed
Jul 17, 2020
Nashenas88
force-pushed
the
packed-ref-unsafe
branch
from
e5b3cd8 to
23f2496
Compare
Nashenas88
force-pushed
the
packed-ref-unsafe
branch
from
23f2496 to
e0cb2f5
Compare
matklad
reviewed
Jul 23, 2020
matklad
reviewed
Jul 23, 2020
| } else { | ||
| None | ||
| } | ||
| })(); |
Contributor
There was a problem hiding this comment.
Self-invoking closures are neat, but is there perhaps a way to write this simpler, without deploying intricate language machinery?
Contributor
Author
There was a problem hiding this comment.
Cleaned up. Does the new version need comments or is it pretty clear?
matklad
reviewed
Jul 23, 2020
matklad
reviewed
Jul 23, 2020
matklad
reviewed
Jul 30, 2020
Nashenas88
force-pushed
the
packed-ref-unsafe
branch
from
f3997b6 to
a8433d4
Compare
Nashenas88
force-pushed
the
packed-ref-unsafe
branch
3 times, most recently
from
bc47803 to
017c8b2
Compare
Taking a reference to a misaligned field on a packed struct is an unsafe operation. Highlight that behavior. Currently, the misaligned part isn't tracked, so this highlight is a bit too aggressive.
…r, remove debug println.
… missing support for autoref behavior
…g, auto ref function calls
…irst param for self information in syntax highlighting instead
…plify repr attr lookup
…ator, using functional methods rather than clunky inline closure
Nashenas88
force-pushed
the
packed-ref-unsafe
branch
from
0718d7c to
72baf1a
Compare
Contributor
|
bors r+ |
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taking a reference to a misaligned field on a packed struct is an
unsafe operation. Highlight that behavior. Currently, the misaligned
part isn't tracked, so this highlight is a bit too aggressive.
Fixes #4600