Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Clippy to CI #55

Merged
merged 1 commit into from Jul 29, 2018
Merged

Add Clippy to CI #55

merged 1 commit into from Jul 29, 2018

Conversation

phansch
Copy link
Member

@phansch phansch commented Jul 29, 2018

Fixes #19

@phansch
Copy link
Member Author

phansch commented Jul 29, 2018

Let's see how much Clippy is suggesting? Feel free to close the PR if it gets in the way right now 👍

@matklad
Copy link
Member

matklad commented Jul 29, 2018

Oh, I am unfortunately in the middle of rewriting significant chunks of the library :(

I’ll get to this PR eventually, but probably not today :-)

@phansch
Copy link
Member Author

phansch commented Jul 29, 2018

That's what I saw :) In any case, so far it looks like there are only ~10 suggestions by Clippy.

@matklad
Copy link
Member

matklad commented Jul 29, 2018

bors r+

bors bot added a commit that referenced this issue Jul 29, 2018
55: Add Clippy to CI r=matklad a=phansch

Fixes #19 

Co-authored-by: Philipp Hansch <dev@phansch.net>
@matklad
Copy link
Member

matklad commented Jul 29, 2018

Let's just see how this works out :D

@bors
Copy link
Contributor

bors bot commented Jul 29, 2018

@bors bors bot merged commit 7e0a84c into rust-lang:master Jul 29, 2018
3 checks passed
@phansch phansch deleted the add_clippy_to_ci branch Jul 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants