Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upDerive PartialOrd when possible #1002
Conversation
pepyakin
added some commits
Sep 19, 2017
highfive
assigned
fitzgen
Sep 19, 2017
highfive
added
the
S-awaiting-review
label
Sep 19, 2017
This comment has been minimized.
This comment has been minimized.
|
This looks good! We just need some test coverage to land this. Let's add
And then verify that the generated bindings do or don't Thanks! |
This comment has been minimized.
This comment has been minimized.
|
@pepyakin, BTW, I'm not sure if you're aware that the "impl period" has just begun, but the folks hacking on |
This comment has been minimized.
This comment has been minimized.
|
@bors-servo r+ Thanks @pepyakin ! |
This comment has been minimized.
This comment has been minimized.
|
|
highfive
added
S-awaiting-merge
and removed
S-awaiting-review
labels
Sep 19, 2017
This comment has been minimized.
This comment has been minimized.
bors-servo
added a commit
that referenced
this pull request
Sep 19, 2017
This comment has been minimized.
This comment has been minimized.
|
|
1 similar comment
This comment has been minimized.
This comment has been minimized.
|
|
pepyakin commentedSep 19, 2017
Fixes #882
r? @fitzgen