Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Derive PartialOrd when possible #1002

Merged
merged 5 commits into from Sep 19, 2017

Conversation

Projects
None yet
4 participants
@pepyakin
Copy link
Contributor

pepyakin commented Sep 19, 2017

Fixes #882

r? @fitzgen

@fitzgen

This comment has been minimized.

Copy link
Member

fitzgen commented Sep 19, 2017

This looks good!

We just need some test coverage to land this. Let's add --with-derive-partialord to the // bindgen-flags line for these tests:

  • tests/headers/derive-hash-template-inst-float.hpp
  • tests/headers/derive-hash-template-def-float.hpp
  • tests/headers/derive-hash-struct-with-pointer.h
  • tests/headers/derive-hash-struct-with-float-array.h
  • tests/headers/derive-hash-struct-with-anon-struct-float.h
  • tests/headers/derive-hash-blacklisting.hpp

And then verify that the generated bindings do or don't derive(PartialOrd) as we expect them to.

Thanks!

@fitzgen

This comment has been minimized.

Copy link
Member

fitzgen commented Sep 19, 2017

@pepyakin, BTW, I'm not sure if you're aware that the "impl period" has just begun, but the folks hacking on bindgen during the impl period are hanging out in https://gitter.im/rust-impl-period/WG-dev-tools-bindgen if you want to join us :)

@fitzgen

This comment has been minimized.

Copy link
Member

fitzgen commented Sep 19, 2017

@bors-servo r+

Thanks @pepyakin !

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Sep 19, 2017

📌 Commit e4a4b47 has been approved by fitzgen

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Sep 19, 2017

⌛️ Testing commit e4a4b47 with merge 1906a26...

bors-servo added a commit that referenced this pull request Sep 19, 2017

Auto merge of #1002 - pepyakin:derive-partialord-when-possible, r=fit…
…zgen

Derive PartialOrd when possible

Fixes #882

r? @fitzgen
@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Sep 19, 2017

☀️ Test successful - status-travis
Approved by: fitzgen
Pushing 1906a26 to master...

1 similar comment
@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Sep 19, 2017

☀️ Test successful - status-travis
Approved by: fitzgen
Pushing 1906a26 to master...

@bors-servo bors-servo merged commit e4a4b47 into rust-lang:master Sep 19, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details

@pepyakin pepyakin deleted the pepyakin:derive-partialord-when-possible branch Sep 19, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.