Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upDerive ord when possible #1003
Conversation
pepyakin
added some commits
Sep 19, 2017
highfive
assigned
fitzgen
Sep 19, 2017
highfive
added
the
S-awaiting-review
label
Sep 19, 2017
This comment has been minimized.
This comment has been minimized.
|
@bors-servo r+ |
This comment has been minimized.
This comment has been minimized.
|
|
highfive
added
S-awaiting-merge
and removed
S-awaiting-review
labels
Sep 19, 2017
This comment has been minimized.
This comment has been minimized.
bors-servo
added a commit
that referenced
this pull request
Sep 19, 2017
This comment has been minimized.
This comment has been minimized.
|
|
highfive
added
S-tests-failed
and removed
S-awaiting-merge
labels
Sep 19, 2017
This comment has been minimized.
This comment has been minimized.
|
(Note that Travis CI got stuck so I canceled and restarted a job, that isn't actually a test failure) |
This comment has been minimized.
This comment has been minimized.
|
|
bors-servo
merged commit 27dad0b
into
rust-lang:master
Sep 19, 2017
pepyakin
deleted the
pepyakin:derive-ord-when-possible
branch
Sep 21, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
pepyakin commentedSep 19, 2017
Fixes #884
r? @fitzgen