Skip to content

/rust-bindgen

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

codegen: Avoid generating wrong type for enums with unknown representation #1030

Merged
merged 1 commit into from Sep 25, 2017

Conversation

Reviewers

@fitzgen fitzgen

Assignees

@fitzgen fitzgen

Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@emilio @fitzgen @bors-servo @highfive
@emilio
Copy link
Collaborator

emilio commented Sep 24, 2017

Fixes #1025

@highfive highfive added the S-awaiting-review label Sep 24, 2017

@emilio

This comment has been minimized.

Sign in to view
Copy link
Collaborator Author

emilio commented Sep 24, 2017

r? @fitzgen

@highfive highfive assigned fitzgen Sep 24, 2017

@emilio
codegen: Avoid generating wrong type for enums with unknown represent… 
…ations.
Verified
This commit was signed with a verified signature.
@emilio emilio Emilio Cobos Álvarez
GPG key ID: 056B727BB9C1027C Learn about signing commits
Loading status checks…
39765b8

@emilio emilio force-pushed the emilio:repr branch from c489fe6 to 39765b8 Sep 25, 2017

@fitzgen

fitzgen approved these changes Sep 25, 2017
View changes

Copy link
Member

fitzgen left a comment

👍
@fitzgen

This comment has been minimized.

Sign in to view
Copy link
Member

fitzgen commented Sep 25, 2017

@bors-servo r+

Thanks!
@bors-servo

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo commented Sep 25, 2017

📌 Commit 39765b8 has been approved by fitzgen

@highfive highfive added S-awaiting-merge and removed S-awaiting-review labels Sep 25, 2017

@bors-servo

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo commented Sep 25, 2017

⌛️ Testing commit 39765b8 with merge 40a3c07...

bors-servo added a commit that referenced this pull request Sep 25, 2017

@bors-servo
Auto merge of #1030 - emilio:repr, r=fitzgen 
codegen: Avoid generating wrong type for enums with unknown representation

Fixes #1025
Loading status checks…
40a3c07
@bors-servo

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo commented Sep 25, 2017

💔 Test failed - status-travis

@highfive highfive added S-tests-failed and removed S-awaiting-merge labels Sep 25, 2017

@fitzgen

This comment has been minimized.

Sign in to view
Copy link
Member

fitzgen commented Sep 25, 2017

@emilio it looks like someone canceled this CI run -- did you by chance?
@emilio

This comment has been minimized.

Sign in to view
Copy link
Collaborator Author

emilio commented Sep 25, 2017

Not really, shrug.

@bors-servo retry
@bors-servo

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo commented Sep 25, 2017

⌛️ Testing commit 39765b8 with merge 8f3c575...

bors-servo added a commit that referenced this pull request Sep 25, 2017

@bors-servo
Auto merge of #1030 - emilio:repr, r=fitzgen 
codegen: Avoid generating wrong type for enums with unknown representation

Fixes #1025
Loading status checks…
8f3c575

@highfive highfive added S-awaiting-merge and removed S-tests-failed labels Sep 25, 2017

@bors-servo

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo commented Sep 25, 2017

☀️ Test successful - status-travis
Approved by: fitzgen
Pushing 8f3c575 to master...

@bors-servo bors-servo merged commit 39765b8 into rust-lang:master Sep 25, 2017
2 checks passed

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details

@highfive highfive removed the S-awaiting-merge label Sep 25, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.