Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upIssue #1037: pass all derive-enabling flags in bindgen for csmith driver #1043
Conversation
highfive
assigned
fitzgen
Sep 27, 2017
This comment has been minimized.
This comment has been minimized.
|
Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @fitzgen (or someone else) soon. |
highfive
added
the
S-awaiting-review
label
Sep 27, 2017
This comment has been minimized.
This comment has been minimized.
|
@bors-servo r+ |
This comment has been minimized.
This comment has been minimized.
|
|
highfive
added
S-awaiting-merge
and removed
S-awaiting-review
labels
Sep 28, 2017
This comment has been minimized.
This comment has been minimized.
bors-servo
added a commit
that referenced
this pull request
Sep 28, 2017
This comment has been minimized.
This comment has been minimized.
|
|
highfive
added
S-tests-failed
and removed
S-awaiting-merge
labels
Sep 28, 2017
This comment has been minimized.
This comment has been minimized.
|
looks like it fails in building rustfmt-nightly in CI. so does it need a re-run? |
This comment has been minimized.
This comment has been minimized.
I think it was rust-lang/rustfmt#2002, which now appears to be fixed. I'll go ahead and merge this manually though. Sorry for the hiccup! |
fitzgen
merged commit c160b20
into
rust-lang:master
Sep 29, 2017
clippered
referenced this pull request
Oct 11, 2017
Closed
Our C-Smith driver should ask bindgen to derive everything #1037
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
clippered commentedSep 27, 2017
r? @fitzgen