Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upir: Prefer using known semantic parents #1049
Conversation
highfive
assigned
emilio
Sep 29, 2017
highfive
added
the
S-awaiting-review
label
Sep 29, 2017
This comment has been minimized.
This comment has been minimized.
|
|
fitzgen
referenced this pull request
Sep 29, 2017
Closed
error[E0428]: the name `sentry` is defined multiple times #1048
This comment has been minimized.
This comment has been minimized.
|
@bors-servo r+ Thanks! |
This comment has been minimized.
This comment has been minimized.
|
|
highfive
added
S-awaiting-merge
and removed
S-awaiting-review
labels
Oct 1, 2017
This comment has been minimized.
This comment has been minimized.
bors-servo
added a commit
that referenced
this pull request
Oct 1, 2017
This comment has been minimized.
This comment has been minimized.
|
|
highfive
added
S-tests-failed
and removed
S-awaiting-merge
labels
Oct 1, 2017
This comment has been minimized.
This comment has been minimized.
ctaggart
commented
Oct 2, 2017
|
Is this a valid test failure or does CI just need to run again? |
This comment has been minimized.
This comment has been minimized.
Restarted. Unsure why it was cancelled... |
This comment has been minimized.
This comment has been minimized.
|
|
bors-servo
merged commit 64d73c2
into
rust-lang:master
Oct 2, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
fitzgen commentedSep 29, 2017
When choosing a parent ID for a type that we are parsing, prefer known semantic parents over the provided parent ID. It seems like we shouldn't even be passing explicit parent IDs around (they're often buggy), and instead should expand the
known_semantic_parentinfrastructure, but I'll leave that to some future work.Fixes #1048
r? @emilio