Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upRemove early anonymous bitfield filtering and consolidate name method #1059
Conversation
highfive
added
the
S-awaiting-review
label
Oct 4, 2017
fitzgen
reviewed
Oct 4, 2017
| ) | ||
| ); | ||
| assert_eq ! ( :: std :: mem :: size_of :: < foo < f32 > > ( ) , 4usize , concat ! ( "Size of template specialization: " , stringify ! ( foo < f32 > ) ) ); | ||
| assert_eq ! ( :: std :: mem :: align_of :: < foo < f32 > > ( ) , 4usize , concat ! ( "Alignment of template specialization: " , stringify ! ( foo < f32 > ) ) ); |
This comment has been minimized.
This comment has been minimized.
fitzgen
Oct 4, 2017
Member
I think if you update to the latest rustfmt then it should preserve the old formatting here.
$ rustup update nightly
$ cargo +nightly install rustfmt-nightly
This comment has been minimized.
This comment has been minimized.
|
@fitzgen I think that fixed it, yea I did have an outdated version of rustfmt. I left it in because I thought that if it happened on the CI test it would fail, so I would need to keep it in, but I realize now that wouldn't have happened because it was just my rustfmt version. |
This comment has been minimized.
This comment has been minimized.
|
@bors-servo r+ Thank you very much @aeleos ! |
This comment has been minimized.
This comment has been minimized.
|
|
highfive
assigned
fitzgen
Oct 4, 2017
highfive
added
S-awaiting-merge
and removed
S-awaiting-review
labels
Oct 4, 2017
This comment has been minimized.
This comment has been minimized.
bors-servo
added a commit
that referenced
this pull request
Oct 4, 2017
This comment has been minimized.
This comment has been minimized.
|
|
highfive
added
S-tests-failed
and removed
S-awaiting-merge
labels
Oct 4, 2017
This comment has been minimized.
This comment has been minimized.
|
I don't understand why our CI pushes get immediately cancelled all the time now... Restarted. |
This comment has been minimized.
This comment has been minimized.
|
|
aeleos commentedOct 4, 2017
•
edited by fitzgen
This PR is some changes to early bitfield filtering to help fix (#1007) This does not close (#1007), but allows for checking if the bitfield is too large during a later stage.
@fitzgen r?