Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upExplicit vtable pointer refactor #1084
Conversation
highfive
assigned
emilio
Oct 13, 2017
This comment has been minimized.
This comment has been minimized.
|
|
highfive
added
the
S-awaiting-review
label
Oct 13, 2017
src/ir/analysis/has_vtable.rs
Outdated
| } | ||
|
|
||
| TypeKind::Comp(ref info) => { | ||
| trace!(" comp considers its own methods and bases"); | ||
| let mut result = HasVtableResult::default(); |
This comment has been minimized.
This comment has been minimized.
emilio
Oct 21, 2017
Collaborator
I think it's clearer and shorter if you use No here directly instead of default.
fitzgen
added some commits
Oct 13, 2017
fitzgen
force-pushed the
fitzgen:explicit-vtable-pointer-refactor
branch
from
28ebbc6
to
6f87f0b
Oct 23, 2017
This comment has been minimized.
This comment has been minimized.
|
Addressed feedback and rebased -- thanks @emilio ! @bors-servo r+ |
This comment has been minimized.
This comment has been minimized.
|
|
highfive
assigned
fitzgen
and unassigned
emilio
Oct 23, 2017
highfive
added
S-awaiting-merge
and removed
S-awaiting-review
labels
Oct 23, 2017
This comment has been minimized.
This comment has been minimized.
bors-servo
added a commit
that referenced
this pull request
Oct 23, 2017
This comment has been minimized.
This comment has been minimized.
|
|
bors-servo
merged commit 6f87f0b
into
rust-lang:master
Oct 23, 2017
highfive
removed
the
S-awaiting-merge
label
Oct 23, 2017
This was referenced Oct 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
fitzgen commentedOct 13, 2017
•
edited
r? @emilio
This should make it easier to move padding into its own pass, rather than inside codegen, which should in turn let us start handling (or at least intelligently determining when we can't handle)
#pragma pack(..)and other things that affect layout in exotic ways that we can only indirectly observe.See each commit for details.
The reason for the first commit is this: when we compare, we rustfmt both expected and actual, so the expectations don't get updated to be formatted nicely until some patch that changes what gets generated. This is annoying, however, when debugging some minor difference, and not being able to see what it is easily. Best to just bite the bullet and format all the expectations the once and make the problem go away.