Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upDerive `Clone` along with `Copy` on Rust 1.21 #1085
Conversation
highfive
assigned
fitzgen
Oct 14, 2017
This comment has been minimized.
This comment has been minimized.
|
|
highfive
added
the
S-awaiting-review
label
Oct 14, 2017
pepyakin
force-pushed the
pepyakin:builtin-clone-impls
branch
from
e337ceb
to
e3e0db1
Oct 14, 2017
fitzgen
approved these changes
Oct 17, 2017
src/codegen/mod.rs
Outdated
| derives.push("Clone"); | ||
| } else { | ||
| needs_clone_impl = true; | ||
| if used_template_params.is_some() { |
This comment has been minimized.
This comment has been minimized.
fitzgen
Oct 17, 2017
Member
Flatten the nested if/else?
if ctx.options().rust_features().builtin_clone_impls() || used_template_params.is_some() {
...
} else {
...
}
pepyakin
force-pushed the
pepyakin:builtin-clone-impls
branch
from
e3e0db1
to
1886fe2
Oct 23, 2017
This comment has been minimized.
This comment has been minimized.
|
@fitzgen done! |
This comment has been minimized.
This comment has been minimized.
|
@bors-servo r+ |
This comment has been minimized.
This comment has been minimized.
|
|
highfive
added
S-awaiting-merge
and removed
S-awaiting-review
labels
Oct 23, 2017
This comment has been minimized.
This comment has been minimized.
|
|
This comment has been minimized.
This comment has been minimized.
|
|
highfive
added
S-needs-rebase
and removed
S-awaiting-merge
labels
Oct 23, 2017
pepyakin
force-pushed the
pepyakin:builtin-clone-impls
branch
from
1886fe2
to
f0e97bb
Oct 23, 2017
highfive
added
the
S-awaiting-review
label
Oct 23, 2017
This comment has been minimized.
This comment has been minimized.
|
|
highfive
added
the
S-needs-rebase
label
Oct 24, 2017
pepyakin
force-pushed the
pepyakin:builtin-clone-impls
branch
from
f0e97bb
to
a84e263
Oct 24, 2017
pepyakin
force-pushed the
pepyakin:builtin-clone-impls
branch
from
a84e263
to
2e7d997
Oct 24, 2017
This comment has been minimized.
This comment has been minimized.
|
@bors-servo r=fitzgen |
This comment has been minimized.
This comment has been minimized.
|
|
highfive
removed
the
S-awaiting-review
label
Oct 24, 2017
This comment has been minimized.
This comment has been minimized.
highfive
added
S-awaiting-merge
and removed
S-needs-rebase
labels
Oct 24, 2017
bors-servo
added a commit
that referenced
this pull request
Oct 24, 2017
This comment has been minimized.
This comment has been minimized.
|
|
bors-servo
merged commit 2e7d997
into
rust-lang:master
Oct 24, 2017
highfive
removed
the
S-awaiting-merge
label
Oct 24, 2017
pepyakin
deleted the
pepyakin:builtin-clone-impls
branch
Oct 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
pepyakin commentedOct 14, 2017
Fixes #934
r? @fitzgen or @emilio