Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upResolve #962 - implement --no-copy with tests #1099
Conversation
highfive
added
the
S-awaiting-review
label
Oct 25, 2017
This comment has been minimized.
This comment has been minimized.
|
|
This comment has been minimized.
This comment has been minimized.
|
r?@fitzgen |
highfive
assigned
fitzgen
Oct 25, 2017
fitzgen
approved these changes
Oct 25, 2017
|
Looks great! Could you also extend the documentation at https://rust-lang-nursery.github.io/rust-bindgen/nocopy.html to account for this change? ( Thanks @hallfox ! |
src/ir/context.rs
Outdated
| @@ -2455,8 +2455,16 @@ impl BindgenContext { | |||
| /// Check if `--no-partialeq` flag is enabled for this item. | |||
| pub fn no_partialeq_by_name(&self, item: &Item) -> bool { | |||
| let name = item.canonical_path(self)[1..].join("::"); | |||
|
|
|||
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@bors-servo delegate+ |
This comment has been minimized.
This comment has been minimized.
|
|
This comment has been minimized.
This comment has been minimized.
|
@bors-servo r+ |
This comment has been minimized.
This comment has been minimized.
|
|
highfive
added
S-awaiting-merge
and removed
S-awaiting-review
labels
Oct 26, 2017
This comment has been minimized.
This comment has been minimized.
bors-servo
added a commit
that referenced
this pull request
Oct 26, 2017
This comment has been minimized.
This comment has been minimized.
|
|
bors-servo
merged commit f7e370a
into
rust-lang:master
Oct 26, 2017
highfive
removed
the
S-awaiting-merge
label
Oct 26, 2017
This was referenced Oct 26, 2017
hallfox
deleted the
hallfox:no-copy
branch
Oct 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
hallfox commentedOct 25, 2017
Allows types to not have the copy trait automatically derived.