Skip to content

/rust-bindgen

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ir: References have no implicit template parameters. #1114

Merged
merged 1 commit into from Oct 28, 2017

Conversation

Reviewers

@pepyakin pepyakin

Assignees

@pepyakin pepyakin

Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@emilio @highfive @pepyakin @bors-servo @fitzgen
@emilio
Copy link
Collaborator

emilio commented Oct 28, 2017

Fixes #1113.
@emilio
ir: References have no implicit template parameters. 
Fixes #1113.
Verified
This commit was signed with a verified signature.
@emilio emilio Emilio Cobos Álvarez
GPG key ID: 056B727BB9C1027C Learn about signing commits
Loading status checks…
0630f46
@highfive

This comment has been minimized.

Sign in to view
Copy link
Collaborator

highfive commented Oct 28, 2017

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!

@highfive highfive added the S-awaiting-review label Oct 28, 2017

@emilio

This comment has been minimized.

Sign in to view
Copy link
Collaborator Author

emilio commented Oct 28, 2017

r? @fitzgen or @pepyakin

@highfive highfive assigned fitzgen Oct 28, 2017

@pepyakin

pepyakin approved these changes Oct 28, 2017
View changes

Copy link
Contributor

pepyakin left a comment

👍
@pepyakin

This comment has been minimized.

Sign in to view
Copy link
Contributor

pepyakin commented Oct 28, 2017

@bors-servo r+
@bors-servo

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo commented Oct 28, 2017

📌 Commit 0630f46 has been approved by pepyakin

@highfive highfive assigned pepyakin and unassigned fitzgen Oct 28, 2017

@highfive highfive added S-awaiting-merge and removed S-awaiting-review labels Oct 28, 2017

@bors-servo

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo commented Oct 28, 2017

⌛️ Testing commit 0630f46 with merge c7f0fab...

bors-servo added a commit that referenced this pull request Oct 28, 2017

@bors-servo
Auto merge of #1114 - emilio:template-params-ref, r=pepyakin 
ir: References have no implicit template parameters.

Fixes #1113.
Loading status checks…
c7f0fab
@bors-servo

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo commented Oct 28, 2017

☀️ Test successful - status-travis
Approved by: pepyakin
Pushing c7f0fab to master...

@bors-servo bors-servo merged commit 0630f46 into rust-lang:master Oct 28, 2017
2 checks passed

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details

@highfive highfive removed the S-awaiting-merge label Oct 28, 2017

emilio added a commit to emilio/rust-bindgen that referenced this pull request Oct 28, 2017

@emilio
Minor version bump. 
Only bugfixes have landed since the last release (rust-lang#1112 and rust-lang#1114), apart from
doc fixes.
Verified
This commit was signed with a verified signature.
@emilio emilio Emilio Cobos Álvarez
GPG key ID: 056B727BB9C1027C Learn about signing commits
Loading status checks…
fefbbb5

@emilio emilio referenced this pull request Oct 28, 2017

Merged

Minor version bump. #1115

bors-servo added a commit that referenced this pull request Oct 28, 2017

@bors-servo
Auto merge of #1115 - emilio:bumpit, r=pepyakin 
Minor version bump.

Only bugfixes have landed since the last release (#1112 and #1114), apart from
doc fixes.
Loading status checks…
77046b7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.