Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upDon't unwrap header metadata #1146
Conversation
highfive
assigned
fitzgen
Nov 10, 2017
highfive
added
the
S-awaiting-review
label
Nov 10, 2017
durka
approved these changes
Nov 10, 2017
This comment has been minimized.
This comment has been minimized.
|
@bors-servo r+ |
This comment has been minimized.
This comment has been minimized.
|
|
highfive
assigned
emilio
and unassigned
fitzgen
Nov 10, 2017
highfive
added
S-awaiting-merge
and removed
S-awaiting-review
labels
Nov 10, 2017
This comment has been minimized.
This comment has been minimized.
bors-servo
added a commit
that referenced
this pull request
Nov 10, 2017
This comment has been minimized.
This comment has been minimized.
|
|
bors-servo
merged commit 7f0aa6c
into
rust-lang:master
Nov 10, 2017
highfive
removed
the
S-awaiting-merge
label
Nov 10, 2017
This comment has been minimized.
This comment has been minimized.
|
Thanks @seemyvest ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
seemyvest commentedNov 10, 2017
Fix for a comment in #1092.
r? @fitzgen