Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upRemove unnecessary flag from rustfmt invocation #1148
Conversation
highfive
added
the
S-awaiting-review
label
Nov 10, 2017
This comment has been minimized.
This comment has been minimized.
|
@bors-servo r+ Thanks @roblabla ! |
This comment has been minimized.
This comment has been minimized.
|
|
highfive
assigned
fitzgen
Nov 10, 2017
highfive
added
S-awaiting-merge
and removed
S-awaiting-review
labels
Nov 10, 2017
bors-servo
added a commit
that referenced
this pull request
Nov 10, 2017
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
|
bors-servo
merged commit a6d4506
into
rust-lang:master
Nov 10, 2017
highfive
removed
the
S-awaiting-merge
label
Nov 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
roblabla commentedNov 10, 2017
•
edited
From rustfmt docs, the --write-mode flag is unecessary when passing the flag to stdin. If we leave it there, rustfmt-nightly complains that it cannot find the file named --write-mode, so let's remove the flag.
here's the logs when I leave the flag :
The build.rs :