Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upAvoid bitfield getters and setters accessing memory beyond "self" #1149
Conversation
highfive
assigned
emilio
Nov 13, 2017
highfive
added
the
S-awaiting-review
label
Nov 13, 2017
emilio
reviewed
Nov 13, 2017
|
Huh, this was actually much easier to fix than what I initially thought, nice job! |
emilio
approved these changes
Nov 13, 2017
This comment has been minimized.
This comment has been minimized.
|
@bors-servo r+ |
This comment has been minimized.
This comment has been minimized.
|
|
highfive
added
S-awaiting-merge
and removed
S-awaiting-review
labels
Nov 13, 2017
This comment has been minimized.
This comment has been minimized.
bors-servo
added a commit
that referenced
this pull request
Nov 13, 2017
This comment has been minimized.
This comment has been minimized.
|
|
bors-servo
merged commit e22d7da
into
rust-lang:master
Nov 13, 2017
highfive
removed
the
S-awaiting-merge
label
Nov 13, 2017
glyn
deleted the
glyn:avoid-accesses-outside-self
branch
Nov 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
glyn commentedNov 13, 2017
This fixes #954.
r? @emilio