Skip to content

/rust-bindgen

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve documentation of the integration tests #1152

Merged
merged 1 commit into from Nov 16, 2017

Conversation

Reviewers

@emilio emilio

Assignees

@emilio emilio

Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@glyn @emilio @bors-servo @highfive
@glyn
Copy link
Contributor

glyn commented Nov 16, 2017

Also note the need to rebuild bindgen when running a single test.

r? @emilio

@highfive highfive assigned emilio Nov 16, 2017

@highfive highfive added the S-awaiting-review label Nov 16, 2017

@glyn

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

glyn commented Nov 16, 2017 •
edited

@emilio I just noticed that the integration tests run against the version of bindgen on the path rather than the version built using the current repository. If that's right, I'll update this PR to mention that. Or is there a way to run the integration tests against the current repository?

Please ignore. The Cargo.lock file in the integration tests needed updating. Don't really understand why, so please let me know if something else needs explaining in the docs!
@glyn
Improve documentation of the integration tests 
Also:
* disable rustfmt in the integration test, to avoid it causing problems, since
  it is not needed.
* note the need to rebuild bindgen when running a single test.
Loading status checks…
6cdf3e2
@glyn

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

glyn commented Nov 16, 2017

@emilio I updated the PR to disable rustfmt in the integration tests.
@emilio

emilio approved these changes Nov 16, 2017
View changes

Copy link
Collaborator

emilio left a comment

Thanks a lot, looks great!
@emilio

This comment has been minimized.

Sign in to view
Copy link
Collaborator

emilio commented Nov 16, 2017

@bors-servo r+
@bors-servo

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo commented Nov 16, 2017

📌 Commit 6cdf3e2 has been approved by emilio

@highfive highfive added S-awaiting-merge and removed S-awaiting-review labels Nov 16, 2017

@bors-servo

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo commented Nov 16, 2017

⌛️ Testing commit 6cdf3e2 with merge 5e0cf9c...

bors-servo added a commit that referenced this pull request Nov 16, 2017

@bors-servo
Auto merge of #1152 - glyn:document-integration-tests, r=emilio 
Improve documentation of the integration tests

Also note the need to rebuild bindgen when running a single test.

r? @emilio
Loading status checks…
5e0cf9c
@bors-servo

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo commented Nov 16, 2017

☀️ Test successful - status-travis
Approved by: emilio
Pushing 5e0cf9c to master...

@bors-servo bors-servo merged commit 6cdf3e2 into rust-lang:master Nov 16, 2017
2 checks passed

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details

@highfive highfive removed the S-awaiting-merge label Nov 16, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.