Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate ptr::null rather than zero literal #1157

Merged
merged 1 commit into from Nov 20, 2017

Conversation

Projects
None yet
4 participants
@tamird
Copy link
Contributor

tamird commented Nov 19, 2017

No description provided.

@emilio
Copy link
Collaborator

emilio left a comment

This looks fine, but can I ask what's the motivation for this change?

@tamird

This comment has been minimized.

Copy link
Contributor Author

tamird commented Nov 19, 2017

Clippy complains about this in crates that use clippy. Easy to ignore, but thought I'd fix it for everyone.

@emilio

emilio approved these changes Nov 20, 2017

Copy link
Collaborator

emilio left a comment

Sounds good, thanks!

@emilio

This comment has been minimized.

Copy link
Collaborator

emilio commented Nov 20, 2017

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Nov 20, 2017

📌 Commit 430fb0e has been approved by emilio

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Nov 20, 2017

⌛️ Testing commit 430fb0e with merge e3e6c73...

bors-servo added a commit that referenced this pull request Nov 20, 2017

Auto merge of #1157 - tamird:use-ptr-null, r=emilio
Generate ptr::null rather than zero literal
@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Nov 20, 2017

☀️ Test successful - status-travis
Approved by: emilio
Pushing e3e6c73 to master...

@bors-servo bors-servo merged commit 430fb0e into rust-lang:master Nov 20, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details

@tamird tamird deleted the tamird:use-ptr-null branch Nov 20, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.