Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upProperly handle namespaces for enum configuration options #1162
Conversation
highfive
assigned
emilio
Nov 27, 2017
highfive
added
the
S-awaiting-review
label
Nov 27, 2017
This comment has been minimized.
This comment has been minimized.
|
Can you add a note to the unreleased section of the changelog about this breaking change? Thanks! |
This comment has been minimized.
This comment has been minimized.
|
And did it fix the issues you were seeing in that other bug? |
tamird
force-pushed the
tamird:enum-naming-consistency
branch
from
27545e2
to
89efc23
Nov 27, 2017
This comment has been minimized.
This comment has been minimized.
|
Added a note to the changelog. I haven't had a chance to test the other issue yet, I may get to it today (but may not). |
This comment has been minimized.
This comment has been minimized.
|
@bors-servo r+ |
This comment has been minimized.
This comment has been minimized.
|
|
highfive
added
S-awaiting-merge
and removed
S-awaiting-review
labels
Nov 28, 2017
This comment has been minimized.
This comment has been minimized.
bors-servo
added a commit
that referenced
this pull request
Nov 28, 2017
This comment has been minimized.
This comment has been minimized.
|
|
bors-servo
merged commit 89efc23
into
rust-lang:master
Nov 28, 2017
highfive
removed
the
S-awaiting-merge
label
Nov 28, 2017
tamird
deleted the
tamird:enum-naming-consistency
branch
Nov 28, 2017
fitzgen
reviewed
Nov 28, 2017
| rather than its "canonical name", which does not. This is a breaking change | ||
| that requires callers which target a namespaced C++ enum to call e.g. | ||
| `bitfield_enum("<namespace>::<enum_name>")` rather than e.g. | ||
| `bitfield_enum("<enum_name>")`. [#1162][] |
This comment has been minimized.
This comment has been minimized.
tamird
referenced this pull request
Nov 28, 2017
Open
rustified_enum doesn't work with anonymous enums #1161
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
tamird commentedNov 27, 2017
...by using canonical_path rather than canonical_name.
Fixes #1125.
r? @emilio