Skip to content

/rust-bindgen

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary ci jobs #1163

Merged
merged 2 commits into from Nov 28, 2017

Conversation

Reviewers

@emilio emilio

Assignees

@emilio emilio

Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@fitzgen @emilio @bors-servo @highfive
@fitzgen
Copy link
Member

fitzgen commented Nov 28, 2017

And then in the process I noticed that we weren't running the layout tests for any of the libclang version-specific expectation files, so I also fixed that.

r? @emilio or @pepyakin

fitzgen added some commits Nov 28, 2017

@fitzgen
Don't run test expectations' layout tests with multiple libclang vers… 
…ions

Only generating bindings depends on which libclang version we are dealing
with. Running the test expectations' layout tests does not change between
libclang versions, so these were redundant tests.

Note that we have not been testing the expected bindings that differ across
libclang versions (the nested sub-directories aren't automatically picked up by
cargo) and this commit does not change that.
5011ddc
@fitzgen
Ensure that we run layout tests from libclang version-specific expect… 
…ations

This adds a build.rs to generate

    #[path="$FILE"]
    mod $FILE_AS_IDENT;

for each $FILE in our libclang version-specific directories. We need to do this
to get those files' layout tests to run because cargo doesn't automatically pick
up tests in subdirectories.
Loading status checks…
1c2172f

@highfive highfive assigned emilio Nov 28, 2017

@highfive highfive added the S-awaiting-review label Nov 28, 2017

@emilio

emilio approved these changes Nov 28, 2017
View changes

@emilio

This comment has been minimized.

Sign in to view
Copy link
Collaborator

emilio commented Nov 28, 2017

@bors-servo r+
@bors-servo

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo commented Nov 28, 2017

📌 Commit 1c2172f has been approved by emilio

@highfive highfive added S-awaiting-merge and removed S-awaiting-review labels Nov 28, 2017

@bors-servo

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo commented Nov 28, 2017

⌛️ Testing commit 1c2172f with merge 0af9c89...

bors-servo added a commit that referenced this pull request Nov 28, 2017

@bors-servo
Auto merge of #1163 - fitzgen:remove-unnecessary-ci-jobs, r=emilio 
Remove unnecessary ci jobs

And then in the process I noticed that we weren't running the layout tests for any of the libclang version-specific expectation files, so I also fixed that.

r? @emilio or @pepyakin
Loading status checks…
0af9c89
@bors-servo

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo commented Nov 28, 2017

☀️ Test successful - status-travis
Approved by: emilio
Pushing 0af9c89 to master...

@bors-servo bors-servo merged commit 1c2172f into rust-lang:master Nov 28, 2017
2 checks passed

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details

@highfive highfive removed the S-awaiting-merge label Nov 28, 2017

@fitzgen

This comment has been minimized.

Sign in to view
Copy link
Member Author

fitzgen commented Nov 28, 2017

Thanks @emilio !
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.