Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upMove tokens method from TranslationUnit to Cursor #1173
Conversation
This comment has been minimized.
This comment has been minimized.
|
|
highfive
added
the
S-awaiting-review
label
Dec 3, 2017
emilio
approved these changes
Dec 3, 2017
This comment has been minimized.
This comment has been minimized.
|
@bors-servo r+ |
This comment has been minimized.
This comment has been minimized.
|
|
highfive
assigned
emilio
Dec 3, 2017
highfive
added
S-awaiting-merge
and removed
S-awaiting-review
labels
Dec 3, 2017
bors-servo
added a commit
that referenced
this pull request
Dec 3, 2017
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
|
highfive
added
S-tests-failed
and removed
S-awaiting-merge
labels
Dec 3, 2017
This comment has been minimized.
This comment has been minimized.
|
@bors-servo retry |
bors-servo
added a commit
that referenced
this pull request
Dec 3, 2017
This comment has been minimized.
This comment has been minimized.
highfive
added
S-awaiting-merge
and removed
S-tests-failed
labels
Dec 3, 2017
This comment has been minimized.
This comment has been minimized.
|
|
highfive
added
S-tests-failed
S-awaiting-review
and removed
S-awaiting-merge
S-tests-failed
labels
Dec 3, 2017
This comment has been minimized.
This comment has been minimized.
|
@bors-servo try |
This comment has been minimized.
This comment has been minimized.
bors-servo
added a commit
that referenced
this pull request
Dec 3, 2017
nox
force-pushed the
nox:tokens
branch
2 times, most recently
from
6bbdbcb
to
d076b9d
Dec 3, 2017
emilio
merged commit 935a18e
into
rust-lang:master
Dec 3, 2017
This comment has been minimized.
This comment has been minimized.
|
Larsborsing because it's not clear what to do about rustfmt... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
nox commentedDec 3, 2017
This makes it easier to call it without passing around a TranslationUnit,
which will prove itself useful to parse
__attribute__nodes.