Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdate lazy_static to 1.0 #1176
Conversation
highfive
added
the
S-awaiting-review
label
Dec 4, 2017
This comment has been minimized.
This comment has been minimized.
|
@bors-servo r+ Thanks! |
This comment has been minimized.
This comment has been minimized.
|
|
highfive
assigned
fitzgen
Dec 4, 2017
highfive
added
S-awaiting-merge
and removed
S-awaiting-review
labels
Dec 4, 2017
This comment has been minimized.
This comment has been minimized.
bors-servo
added a commit
that referenced
this pull request
Dec 4, 2017
This comment has been minimized.
This comment has been minimized.
|
|
highfive
added
S-tests-failed
and removed
S-awaiting-merge
labels
Dec 4, 2017
This comment has been minimized.
This comment has been minimized.
|
Ow, didn't see bindgen shipped a lock file. Should I update it or should we wait for nagisa/rust_libloading#33 to land (to avoid the duplicated dependency) ? |
This comment has been minimized.
This comment has been minimized.
|
Let's wait. |
Eijebong
force-pushed the
Eijebong:bump
branch
from
47552bb
to
5c7b7af
Dec 7, 2017
highfive
added
S-awaiting-review
and removed
S-tests-failed
labels
Dec 7, 2017
This comment has been minimized.
This comment has been minimized.
|
Done :) |
This comment has been minimized.
This comment has been minimized.
|
Thanks @Eijebong ! @bors-servo r+ |
This comment has been minimized.
This comment has been minimized.
|
|
highfive
added
S-awaiting-merge
and removed
S-awaiting-review
labels
Dec 7, 2017
This comment has been minimized.
This comment has been minimized.
bors-servo
added a commit
that referenced
this pull request
Dec 7, 2017
This comment has been minimized.
This comment has been minimized.
|
|
bors-servo
merged commit 5c7b7af
into
rust-lang:master
Dec 7, 2017
highfive
removed
the
S-awaiting-merge
label
Dec 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Eijebong commentedDec 4, 2017
No description provided.