Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upEnable Cargo features for quickchecking crate #1180
Conversation
highfive
assigned
fitzgen
Dec 8, 2017
highfive
added
the
S-awaiting-review
label
Dec 8, 2017
CONTRIBUTING.md
Outdated
| @@ -224,6 +225,14 @@ uncover hidden bugs is by running `csmith` to generate random headers to test | |||
|
|
|||
| See [./csmith-fuzzing/README.md](./csmith-fuzzing/README.md) for details. | |||
|
|
|||
| ### Property tests for `bindgen` with `quickchecking` | |||
|
|
|||
| The `tests/quickchecking` crate genertates property tests for `bindgen`. | |||
This comment has been minimized.
This comment has been minimized.
| `cargo run`. Additional configuration is exposed through the binary's CLI. | ||
|
|
||
| ``` | ||
| $ cargo run --bin=quickchecking -- -h |
This comment has been minimized.
This comment has been minimized.
fitzgen
Dec 8, 2017
Member
I think it makes sense to only show the -h or --help command invocation, and leave out the command's output. As we add more options/flags the output will change and it is likely we will forget to update this code block.
This comment has been minimized.
This comment has been minimized.
|
@bors-servo delegate+ |
This comment has been minimized.
This comment has been minimized.
|
|
This comment has been minimized.
This comment has been minimized.
|
@bors-servo r=fitzgen |
This comment has been minimized.
This comment has been minimized.
|
|
highfive
added
S-awaiting-merge
and removed
S-awaiting-review
labels
Dec 9, 2017
This comment has been minimized.
This comment has been minimized.
bors-servo
added a commit
that referenced
this pull request
Dec 9, 2017
This comment has been minimized.
This comment has been minimized.
|
|
bors-servo
merged commit 2778fe5
into
rust-lang:master
Dec 9, 2017
highfive
removed
the
S-awaiting-merge
label
Dec 9, 2017
shnewto
deleted the
shnewto:feat/quickchecking-cargo-features
branch
Dec 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
shnewto commentedDec 8, 2017
Logic to enable/disable special casing (due to known issues #550, #684, and #1153) has been exposed as features in the
quickcheckingcrate's Cargo.toml file and correspondingcfgattributes in the source.In addition to adding Cargo features, this PR represents the following:
bindgen's CONTRIBUTING.md that points to a new README.md located in thequickcheckingcrate's directory.HeaderCtype. This enables failing property tests to be reported as C source code rather than a Rust data structure.Thanks for taking a look and for any feedback!
Closes #1169
r? @fitzgen