Enable Cargo features for quickchecking crate #1180
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Logic to enable/disable special casing (due to known issues #550, #684, and #1153) has been exposed as features in the `quickchecking` crate's Cargo.toml file and corresponding `cfg` attributes in the source. In addition to adding Cargo features, this PR represents the following: - Documentation in `bindgen`'s CONTRIBUTING.md that points to a new README.md located in the `quickchecking` crate's directory. - The Debug trait was implemented for the `HeaderC` type. This enables failing property tests to be reported as C source code rather than a Rust data structure. - The ArrayDimensionC type is now used in header generation for union, struct, and basic declarations. Thanks for taking a look and for any feedback! Closes #1169 r? @fitzgen
fitzgen
approved these changes
Dec 8, 2017
CONTRIBUTING.md
Outdated
|
|
||
| ### Property tests for `bindgen` with `quickchecking` | ||
|
|
||
| The `tests/quickchecking` crate genertates property tests for `bindgen`. |
| `cargo run`. Additional configuration is exposed through the binary's CLI. | ||
|
|
||
| ``` | ||
| $ cargo run --bin=quickchecking -- -h |
Member
There was a problem hiding this comment.
I think it makes sense to only show the -h or --help command invocation, and leave out the command's output. As we add more options/flags the output will change and it is likely we will forget to update this code block.
Member
|
@bors-servo delegate+ |
|
✌️ @Snewt can now approve this pull request |
- Fixed misspelling introduced in CONTRIBUTING.md - Remove `quickchecking -h` output from README.md
Contributor
Author
|
@bors-servo r=fitzgen |
|
📌 Commit 2778fe5 has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Dec 9, 2017
Enable Cargo features for quickchecking crate Logic to enable/disable special casing (due to known issues #550, #684, and #1153) has been exposed as features in the `quickchecking` crate's Cargo.toml file and corresponding `cfg` attributes in the source. In addition to adding Cargo features, this PR represents the following: - Documentation in `bindgen`'s CONTRIBUTING.md that points to a new README.md located in the `quickchecking` crate's directory. - The Debug trait was implemented for the `HeaderC` type. This enables failing property tests to be reported as C source code rather than a Rust data structure. - The ArrayDimensionC type is now used in header generation for union, struct, and basic declarations. Thanks for taking a look and for any feedback! Closes #1169 r? @fitzgen
|
☀️ Test successful - status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Logic to enable/disable special casing (due to known issues #550, #684, and #1153) has been exposed as features in the
quickcheckingcrate's Cargo.toml file and correspondingcfgattributes in the source.In addition to adding Cargo features, this PR represents the following:
bindgen's CONTRIBUTING.md that points to a new README.md located in thequickcheckingcrate's directory.HeaderCtype. This enables failing property tests to be reported as C source code rather than a Rust data structure.Thanks for taking a look and for any feedback!
Closes #1169
r? @fitzgen