Reintroduce some macOS builds to Travis-CI #1810
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1072 by running a few critical jobs on macOS, but not the whole matrix.
In my experience with Travis in general in the last few years, there has not been a lack of macOS builders as was the case when #1072 (comment) was written.
This PR would increase the number of Travis jobs by four, from
37 to 4131 to 35.Along the way I refactored
ci/before_install.sh
, making it capable of handling LLVM 9.0.1+ (including 10.0.0). Some of the changes there are not strictly necessary to get macOS builds working again, so let me know if I should pare down the list of changes.The most significant change here was to set
LIBCLANG_PATH
instead of onlyDYLD_LIBRARY_PATH
-plus-a-copy. Perhaps it would be better not to setLIBCLANG_PATH
if we could avoid it.