ty: Deal with using shadow types. #2372
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bindgen will fail to detect the size_t typedef if it comes from a using declaration, because we'd try to to look at the canonical type. This is the root cause of https://bugzilla.mozilla.org/show_bug.cgi?id=1795899, an https://bugzilla.mozilla.org/show_bug.cgi?id=1795899#c30 is the reduced test-case. This patch requires an llvm patch to expose the shadow declarations, which I'll submit upstream. This also shows some other progressions as well.
|
☔ The latest upstream changes (presumably 2034a0f) made this pull request unmergeable. Please resolve the merge conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bindgen will fail to detect the size_t typedef if it comes from a using declaration, because we'd try to to look at the canonical type.
This is the root cause of
https://bugzilla.mozilla.org/show_bug.cgi?id=1795899, an https://bugzilla.mozilla.org/show_bug.cgi?id=1795899#c30 is the reduced test-case.
This patch requires an llvm patch to expose the shadow declarations, which I'll submit upstream. This also shows some other progressions as well.