-
Notifications
You must be signed in to change notification settings - Fork 772
ir: Handle char in a more cross-platform way when possible. #610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
r? @fitzgen |
Merged
fitzgen
approved these changes
Apr 3, 2017
Member
|
@bors-servo r+ |
|
📌 Commit 5a25bd6 has been approved by |
|
🔒 Merge conflict |
|
☔ The latest upstream changes (presumably #608) made this pull request unmergeable. Please resolve the merge conflicts. |
Signed-off-by: Emilio Cobos Álvarez <emilio@crisal.io>
Contributor
Author
|
@bors-servo r=fitzgen |
|
📌 Commit 87b3f38 has been approved by |
|
☀️ Test successful - status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should address #603, and supersede #609