Parse negative integers appropriately #74
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's necessary for including some constants from |
|
Can you add a test for this? Adding a file under |
|
Alright, I've made the changes :) |
3 tasks
bors-servo
pushed a commit
to servo/servo
that referenced
this pull request
Oct 4, 2016
Add NS_FONT_STRETCH_* consts and regenerate bindings <!-- Please describe your changes on the following line: --> Depends on rust-lang/rust-bindgen#74 --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build-geckolib` does not report any errors - [x] `./mach test-tidy` does not report any errors <!-- Either: --> - [x] These changes do not require tests because they're autogenerated <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Once that merges, r? @Manishearth <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13566) <!-- Reviewable:end -->
|
I think this is good to merge for now. IIRC upstream bindgen had integrated a C expression parser, so we might want to move to it. Can you squash, then r=me? |
|
I've squashed the test commits, but I'd like to keep the first commit separately, since it makes changes to the code. @bors-servo r=emilio Thanks! :) |
|
📌 Commit 7a39253 has been approved by |
|
⚡ Test exempted - status |
bors-servo
pushed a commit
that referenced
this pull request
Oct 4, 2016
Parse negative integers appropriately Instead of parsing a token at some specified index, we can parse the immediately found literal. Also, this allows negative integers to be parsed as `c_int`s (which is required for some of the constants).
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Feb 4, 2017
…dings (from Wafflespeanut:consts); r=Manishearth <!-- Please describe your changes on the following line: --> Depends on rust-lang/rust-bindgen#74 --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build-geckolib` does not report any errors - [x] `./mach test-tidy` does not report any errors <!-- Either: --> - [x] These changes do not require tests because they're autogenerated <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Once that merges, r? @Manishearth Source-Repo: https://github.com/servo/servo Source-Revision: 6f8bf29eaf3c495cd1c0a4d3bfcccd3c50938541
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 1, 2019
…dings (from Wafflespeanut:consts); r=Manishearth <!-- Please describe your changes on the following line: --> Depends on rust-lang/rust-bindgen#74 --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build-geckolib` does not report any errors - [x] `./mach test-tidy` does not report any errors <!-- Either: --> - [x] These changes do not require tests because they're autogenerated <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Once that merges, r? Manishearth Source-Repo: https://github.com/servo/servo Source-Revision: 6f8bf29eaf3c495cd1c0a4d3bfcccd3c50938541 UltraBlame original commit: 975b16d01ec2e1f4d2c8e5f27da13fe6d24e68bd
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 1, 2019
…dings (from Wafflespeanut:consts); r=Manishearth <!-- Please describe your changes on the following line: --> Depends on rust-lang/rust-bindgen#74 --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build-geckolib` does not report any errors - [x] `./mach test-tidy` does not report any errors <!-- Either: --> - [x] These changes do not require tests because they're autogenerated <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Once that merges, r? Manishearth Source-Repo: https://github.com/servo/servo Source-Revision: 6f8bf29eaf3c495cd1c0a4d3bfcccd3c50938541 UltraBlame original commit: 975b16d01ec2e1f4d2c8e5f27da13fe6d24e68bd
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 1, 2019
…dings (from Wafflespeanut:consts); r=Manishearth <!-- Please describe your changes on the following line: --> Depends on rust-lang/rust-bindgen#74 --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build-geckolib` does not report any errors - [x] `./mach test-tidy` does not report any errors <!-- Either: --> - [x] These changes do not require tests because they're autogenerated <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Once that merges, r? Manishearth Source-Repo: https://github.com/servo/servo Source-Revision: 6f8bf29eaf3c495cd1c0a4d3bfcccd3c50938541 UltraBlame original commit: 975b16d01ec2e1f4d2c8e5f27da13fe6d24e68bd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of parsing a token at some specified index, we can parse the immediately found literal. Also, this allows negative integers to be parsed as
c_ints (which is required for some of the constants).