Move RBE to stable #636
Move RBE to stable #636
Conversation
|
@steveklabnik: no appropriate reviewer found, use r? to override |
|
/cc @mdinger , what do you think about this? |
| @@ -37,7 +37,7 @@ impl Example { | |||
| None => 1, | |||
| Some(ref children) => 1 + children.iter() | |||
| .map(|c| c.count()) | |||
| .sum::<usize>(), | |||
| .fold(0, |sum, i| sum + i), | |||
There was a problem hiding this comment.
That didn't occur to me. Glad you thought of it.
|
Missed the changes to |
steveklabnik
force-pushed
the
stabilize
branch
from
6351827
to
f582264
Compare
This commit moves everything to stable Rust. In it, we lose a few things: * FnBox examples * Associated Constants * Benchmark tests * PathExt stuff * SIMD * Inline Assembly These are varying degrees of unfortunate. A better build system might be able to do nightly vs stable builds for the relevant bits in the future.
| @@ -8,8 +8,6 @@ The valid types for returns are slightly different than before: | |||
|
|
|||
| * `Fn`: normal | |||
| * `FnMut`: normal | |||
| * `FnBox`: equivalent to `FnOnce` but specialized for this application | |||
| because `FnOnce` currently(version 1.1.0) interacts badly with the type system. | |||
There was a problem hiding this comment.
You still may want to comment on it though. People will probably expect the FnOnce analog and so might just think it missing is an omission.
|
Aside from that, I'm pretty okay with this. I would think the biggest loss here is losing slice patterns which are useful to know about (I was certain This seems fine to me. |
|
@mdinger cool, glad we're on the same page. |
|
Nice. +1 from me. |
|
🎊 Nice work @steveklabnik! |
|
Can we add a section of RBE: "Unstable of Rust", and recreate these sections? |
|
@sinistersnare not without significant work on the build process. |
|
Not just the build process. The playpen currently all uses the same environment and would have to be conditionally enabled for just those sections. Currently it doesn't pay attention to which example is being run, just that an example is being run. |
|
And to be clear, I do want that work to happen at some point. It's just not simple. |
This commit moves everything to stable Rust.
In it, we lose a few things:
These are varying degrees of unfortunate. A better build system
might be able to do nightly vs stable builds for the relevant bits
in the future.