New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert to mdbook #897

Merged
merged 29 commits into from Sep 14, 2017

Conversation

Projects
None yet
4 participants
@steveklabnik
Member

steveklabnik commented Sep 12, 2017

Now that mdbook can support the Ace editor (thanks @projektir!),
we can start moving RBE over to mdbook.

So far this is just the first chapter; more to come before this is merged.

rust-lang-nursery/mdBook#338

Fixes #248

Convert first chapter to mdbook
Now that mdbook can support the Ace editor (thanks @projektir!),
we can start moving RBE over to mdbook.

This removes everything but the content, sets up book.toml, and
converts the first chapter.

rust-lang-nursery/mdBook#338
@rust-highfive

This comment has been minimized.

Show comment
Hide comment
@rust-highfive

rust-highfive Sep 12, 2017

@steveklabnik: no appropriate reviewer found, use r? to override

rust-highfive commented Sep 12, 2017

@steveklabnik: no appropriate reviewer found, use r? to override

@steveklabnik

This comment has been minimized.

Show comment
Hide comment
@steveklabnik

steveklabnik Sep 12, 2017

Member

Tests are going to fail since some examples are supposed to fail; gotta sort out what to do about that. If we mark them as "should fail", then it won't add the playpen button, which is annoying since you're supposed to fix them.

Member

steveklabnik commented Sep 12, 2017

Tests are going to fail since some examples are supposed to fail; gotta sort out what to do about that. If we mark them as "should fail", then it won't add the playpen button, which is annoying since you're supposed to fix them.

@steveklabnik steveklabnik referenced this pull request Sep 12, 2017

Closed

Excluding some tests? #434

@steveklabnik

This comment has been minimized.

Show comment
Hide comment
@steveklabnik

steveklabnik Sep 12, 2017

Member

Filed rust-lang-nursery/mdBook#434 for the test issue, this PR is blocking on that.

Member

steveklabnik commented Sep 12, 2017

Filed rust-lang-nursery/mdBook#434 for the test issue, this PR is blocking on that.

@Cldfire Cldfire referenced this pull request Sep 12, 2017

Closed

Support rustbyexample.com #10

@mdinger

This comment has been minimized.

Show comment
Hide comment
@mdinger

mdinger Sep 12, 2017

Contributor

Pretty cool!

Contributor

mdinger commented Sep 12, 2017

Pretty cool!

@steveklabnik

This comment has been minimized.

Show comment
Hide comment
@steveklabnik

steveklabnik Sep 12, 2017

Member

Okay! All chapters are here. Just gotta sort out this test situation, then deployment 👍

Member

steveklabnik commented Sep 12, 2017

Okay! All chapters are here. Just gotta sort out this test situation, then deployment 👍

@steveklabnik

This comment has been minimized.

Show comment
Hide comment
@steveklabnik
Member

steveklabnik commented Sep 12, 2017

Found this bug too: rust-lang-nursery/mdBook#435

@steveklabnik

This comment has been minimized.

Show comment
Hide comment
@steveklabnik

steveklabnik Sep 14, 2017

Member

Time to :shipit: ! This has been a very, very long time coming. Exciting! 🎊

Member

steveklabnik commented Sep 14, 2017

Time to :shipit: ! This has been a very, very long time coming. Exciting! 🎊

@steveklabnik steveklabnik merged commit 0d5f96a into rust-lang:master Sep 14, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@steveklabnik steveklabnik deleted the steveklabnik:mdbook branch Sep 14, 2017

@@ -20,7 +22,33 @@ struct DebugPrintable(i32);
All `std` library types automatically are printable with `{:?}` too:
{debug.play}
```rust,editible

This comment has been minimized.

@berkus

berkus Sep 20, 2017

editible?

@berkus

berkus Sep 20, 2017

editible?

This comment has been minimized.

@steveklabnik

steveklabnik Sep 20, 2017

Member

Yup, this is a bug; want to send in a PR?

@steveklabnik

steveklabnik Sep 20, 2017

Member

Yup, this is a bug; want to send in a PR?

This comment has been minimized.

@berkus

berkus Sep 25, 2017

I can, just a bit too much of PR overhead for a single-letter change.

@berkus

berkus Sep 25, 2017

I can, just a bit too much of PR overhead for a single-letter change.

This comment has been minimized.

@berkus

berkus Sep 25, 2017

Here it is anyway steveklabnik#4

@berkus

berkus Sep 25, 2017

Here it is anyway steveklabnik#4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment