Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert to mdbook #897

Merged
merged 29 commits into from Sep 14, 2017
Merged

Convert to mdbook #897

merged 29 commits into from Sep 14, 2017

Conversation

steveklabnik
Copy link
Member

@steveklabnik steveklabnik commented Sep 12, 2017

Now that mdbook can support the Ace editor (thanks @projektir!),
we can start moving RBE over to mdbook.

So far this is just the first chapter; more to come before this is merged.

https://github.com/azerupi/mdBook/pull/338

Fixes #248

Now that mdbook can support the Ace editor (thanks @projektir!),
we can start moving RBE over to mdbook.

This removes everything but the content, sets up book.toml, and
converts the first chapter.

https://github.com/azerupi/mdBook/pull/338
@rust-highfive
Copy link

@steveklabnik: no appropriate reviewer found, use r? to override

@steveklabnik
Copy link
Member Author

Tests are going to fail since some examples are supposed to fail; gotta sort out what to do about that. If we mark them as "should fail", then it won't add the playpen button, which is annoying since you're supposed to fix them.

@steveklabnik
Copy link
Member Author

Filed https://github.com/azerupi/mdBook/issues/434 for the test issue, this PR is blocking on that.

@mdinger
Copy link
Contributor

mdinger commented Sep 12, 2017

Pretty cool!

@steveklabnik
Copy link
Member Author

Okay! All chapters are here. Just gotta sort out this test situation, then deployment 👍

@steveklabnik
Copy link
Member Author

Found this bug too: https://github.com/azerupi/mdBook/issues/435

@steveklabnik
Copy link
Member Author

Time to :shipit: ! This has been a very, very long time coming. Exciting! 🎊

@@ -20,7 +22,33 @@ struct DebugPrintable(i32);

All `std` library types automatically are printable with `{:?}` too:

{debug.play}
```rust,editible
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

editible?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, this is a bug; want to send in a PR?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can, just a bit too much of PR overhead for a single-letter change.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here it is anyway steveklabnik#4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants