Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promotion shouldn't use curl to download manifests #49

Open
aidanhs opened this Issue Jun 19, 2018 · 2 comments

Comments

Projects
None yet
3 participants
@aidanhs
Copy link
Member

aidanhs commented Jun 19, 2018

This may cause it to download older manifests that we've hacked around with by hand and forgotten to flush the cache of.

Instead it should use aws s3 cp --cache-control none.

cc @Mark-Simulacrum

@aidanhs aidanhs changed the title RCS shouldn't use curl to download manifests Promotion shouldn't use curl to download manifests Jun 19, 2018

@Mark-Simulacrum

This comment has been minimized.

Copy link
Member

Mark-Simulacrum commented Jun 20, 2018

Note that --cache-control none is entirely arbitrary: I have no idea if none is the right thing to pass there.

@alexcrichton

This comment has been minimized.

Copy link
Member

alexcrichton commented Jun 27, 2018

Ah using aws s3 cp should be fine, that goes straight to S3 and avoids all caches

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.