Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promotion should use a consistent date and time #50

Open
aidanhs opened this Issue Jun 19, 2018 · 2 comments

Comments

Projects
None yet
2 participants
@aidanhs
Copy link
Member

aidanhs commented Jun 19, 2018

The sign-and-hash invocation on x.py calls date, but so does RCS on startup. If these straddle a new day, bad things happen.

One big hammer is to use faketime to fix the time at the top level and make every date command return the same value.

@aidanhs

This comment has been minimized.

Copy link
Member Author

aidanhs commented Jun 19, 2018

@aidanhs aidanhs changed the title RCS should use a consistent date and time Promotion should use a consistent date and time Jun 19, 2018

@Mark-Simulacrum

This comment has been minimized.

Copy link
Member

Mark-Simulacrum commented Jun 20, 2018

I think perhaps the better way to fix this is to pull https://github.com/rust-lang/rust/tree/master/src/tools/build-manifest into this repo and then depend on it directly.

This will simplify x.py I think since we can then remove some configuration and a few other things -- HashSign is a really odd step anyway as-is today.

It's not completely trivial since there's some version ready x.py knows of but should be feasible and a good step to take.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.