Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upPromotion should use a consistent date and time #50
Comments
This comment has been minimized.
This comment has been minimized.
aidanhs
changed the title
RCS should use a consistent date and time
Promotion should use a consistent date and time
Jun 19, 2018
This comment has been minimized.
This comment has been minimized.
|
I think perhaps the better way to fix this is to pull https://github.com/rust-lang/rust/tree/master/src/tools/build-manifest into this repo and then depend on it directly. This will simplify x.py I think since we can then remove some configuration and a few other things -- It's not completely trivial since there's some version ready x.py knows of but should be feasible and a good step to take. |
Mark-Simulacrum
referenced this issue
Jun 24, 2018
Open
Align dates in rustup toolchains with those in `rustc -V` #51764
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
aidanhs commentedJun 19, 2018
•
edited
The sign-and-hash invocation on x.py calls
date, but so does RCS on startup. If these straddle a new day, bad things happen.One big hammer is to use
faketimeto fix the time at the top level and make everydatecommand return the same value.