Expand derivable-impls to cover enums with a default unit variant. #10161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @llogiq (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
the
S-waiting-on-review
|
Thank you! @bors r+ |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
facebook-github-bot
pushed a commit
to facebook/sapling
that referenced
this pull request
Mar 24, 2023
Summary: In Rust 1.68.0, the `derivable_impls` clippy lint [got smarter](rust-lang/rust-clippy#10161). Fix all instances of that lint in Mononoke, mute one that's impractical to address. Reviewed By: markbt Differential Revision: D44378068 fbshipit-source-id: 473a051a7001d9596db43f47b56cbad5f5db7efe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please write a short comment explaining your change (or "none" for internal only changes)
changelog: [
derivable_impls]: suggest deriving Default for enums with a default unit variant