Allow implementing Hash with derived PartialEq (derive_hash_xor_eq)
#10184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @xFrednet (or someone else) soon. Please see the contribution instructions for more information. |
rustbot
added
the
S-waiting-on-review
robertbastian
changed the title
Hash with derived PartialEq (derive_hash_xor_eqHash with derived PartialEq (derive_hash_xor_eq
|
The lint name should be changed while you're at it. Something like |
|
Done |
xFrednet
approved these changes
Jan 12, 2023
|
Looks good to me, thank you for the update :) @bors r+ |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
robertbastian
changed the title
Hash with derived PartialEq (derive_hash_xor_eqHash with derived PartialEq (derive_hash_xor_eq)
mizar
added a commit
to mizar/ac-library-rs
that referenced
this pull request
Mar 26, 2023
a4lg
added a commit
to a4lg/ffuzzy
that referenced
this pull request
May 8, 2023
`clippy::derive_hash_xor_eq` is the problem. While it was default error on our current MSRV (1.56), it is now renamed and the meaning of the lint has changed (so that our code is no longer affected by the renamed lint). Related (rust-clippy): Allow implementing `Hash` with derived `PartialEq` (`derive_hash_xor_eq`) <rust-lang/rust-clippy#10184> As a workaround, it disables `renamed_and_removed_lints` lint unless in the maintaince mode.
a4lg
added a commit
to a4lg/ffuzzy
that referenced
this pull request
May 9, 2023
`clippy::derive_hash_xor_eq` is the problem. While it was default error on our current MSRV (1.56), it is now renamed and the meaning of the lint has changed (so that our code is no longer affected by the renamed lint). Related (rust-clippy): Allow implementing `Hash` with derived `PartialEq` (`derive_hash_xor_eq`) <rust-lang/rust-clippy#10184> As a workaround, it disables `renamed_and_removed_lints` lint unless in the maintaince mode. This is a backport from the version 0.2.x development branch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a common pattern and is totally allowed by the
Hashtrait.Fixes #2627
changelog: Move: Renamed
derive_hash_xor_eqto [derived_hash_with_manual_eq]#10184
changelog: Enhancement: [
derived_hash_with_manual_eq]: Now allows#[derive(PartialEq)]with customHashimplementations#10184