Skip to content

Conversation

@ada4a
Copy link
Contributor

@ada4a ada4a commented Nov 1, 2025

changelog: [needless_arbitrary_self_type]: give suggestions with finer diffs

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Nov 1, 2025
@rustbot
Copy link
Collaborator

rustbot commented Nov 1, 2025

r? @y21

rustbot has assigned @y21.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@ada4a ada4a force-pushed the needless_arbitrary_self_type branch from 3c5d3f8 to b698bc2 Compare November 1, 2025 17:09
Copy link
Member

@y21 y21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice improvement :) Do you mind squashing the commits?

View changes since this review

@ada4a ada4a force-pushed the needless_arbitrary_self_type branch from b698bc2 to 6a10b2f Compare November 8, 2025 18:48
@rustbot
Copy link
Collaborator

rustbot commented Nov 8, 2025

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@ada4a ada4a force-pushed the needless_arbitrary_self_type branch from 6a10b2f to a4a88ea Compare November 8, 2025 18:48
@y21 y21 added this pull request to the merge queue Nov 12, 2025
Merged via the queue into rust-lang:master with commit 0ac6646 Nov 12, 2025
11 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Nov 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants